Skip to content

fix(packages): disable non-functional registry login attempt on upgrade#1528

Merged
damyanpetev merged 2 commits intomasterfrom
dpetev/disable-npm-login
Mar 11, 2026
Merged

fix(packages): disable non-functional registry login attempt on upgrade#1528
damyanpetev merged 2 commits intomasterfrom
dpetev/disable-npm-login

Conversation

@damyanpetev
Copy link
Member

@damyanpetev damyanpetev commented Mar 11, 2026

Reducing ensureRegistryUser to more of a helpful check and letting the rest of the work complete.

Additional information related to this pull request:
The current Infragistics licensed feed backend doesn't support npm login correctly assuming all npm versions are 9.4+ at this point, so disabling attempts to run the command in favor of leaving docs link like https://www.infragistics.com/products/ignite-ui-angular/angular/components/general/ignite-ui-licensing

For example the upgrade command, if login isn't found will simply log:
image
and still update the source as requested. If the login is truly not setup the install might fail, that should be expected.

@coveralls
Copy link

coveralls commented Mar 11, 2026

Coverage Status

coverage: 71.088% (-0.2%) from 71.242%
when pulling 6658585 on dpetev/disable-npm-login
into f8e4b59 on master.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables the interactive npm login registry-auth flow during licensed-package upgrades, and updates logs/tests accordingly.

Changes:

  • Introduces a REGISTRY_ATTEMPT_LOGIN flag in PackageManager.ensureRegistryUser() to skip the login attempt when npm whoami fails.
  • Updates the upgrade error message used by updateWorkspace() when registry auth can’t be verified.
  • Adjusts packageManager unit tests to account for the disabled login attempt path.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
spec/unit/packageManager-spec.ts Updates unit test expectations to conditionally assert behavior based on the new login-attempt flag.
packages/core/update/Update.ts Changes the diagnostic message passed into ensureRegistryUser() during workspace updates.
packages/core/packages/PackageManager.ts Adds the feature flag and changes ensureRegistryUser() behavior to skip interactive login attempts.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@damyanpetev damyanpetev merged commit 1008a1e into master Mar 11, 2026
3 checks passed
@damyanpetev damyanpetev deleted the dpetev/disable-npm-login branch March 11, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants