fix(packages): disable non-functional registry login attempt on upgrade#1528
Merged
damyanpetev merged 2 commits intomasterfrom Mar 11, 2026
Merged
fix(packages): disable non-functional registry login attempt on upgrade#1528damyanpetev merged 2 commits intomasterfrom
damyanpetev merged 2 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR disables the interactive npm login registry-auth flow during licensed-package upgrades, and updates logs/tests accordingly.
Changes:
- Introduces a
REGISTRY_ATTEMPT_LOGINflag inPackageManager.ensureRegistryUser()to skip the login attempt whennpm whoamifails. - Updates the upgrade error message used by
updateWorkspace()when registry auth can’t be verified. - Adjusts
packageManagerunit tests to account for the disabled login attempt path.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
spec/unit/packageManager-spec.ts |
Updates unit test expectations to conditionally assert behavior based on the new login-attempt flag. |
packages/core/update/Update.ts |
Changes the diagnostic message passed into ensureRegistryUser() during workspace updates. |
packages/core/packages/PackageManager.ts |
Adds the feature flag and changes ensureRegistryUser() behavior to skip interactive login attempts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Hristo313
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reducing ensureRegistryUser to more of a helpful check and letting the rest of the work complete.
Additional information related to this pull request:
The current Infragistics licensed feed backend doesn't support
npm logincorrectly assuming all npm versions are 9.4+ at this point, so disabling attempts to run the command in favor of leaving docs link like https://www.infragistics.com/products/ignite-ui-angular/angular/components/general/ignite-ui-licensingFor example the upgrade command, if login isn't found will simply log:

and still update the source as requested. If the login is truly not setup the install might fail, that should be expected.