Different names for BDSP in sprites and api repos

[DerCooleJustin]

Hey just a quick note the brilliant-diamond-... folder in gen 8 is named brilliant-diamond-and-shining-pearl in this repo while the game is named brilliant-diamond-shining-pearl.

I think this slipped by here https://github.com/PokeAPI/sprites/pull/139/changes can we you rename that folder to brilliant-diamond-shining-pearl

Originally posted by @FallenDeity in #199 (comment)

===

Making this a new issue for the reason stated here #199 (comment)

[Naramsim]

Hi! Thanks for the catch. World you be able to fix the issue on your own?

[DerCooleJustin]

I definitely am able to fix, but i thought this might deserve a short discussion. It's been like this for 1.5yrs, and might break some older downloaders who don't bother using actual PokeAPI data and instead download directly from GH using hardcoded paths.
I know this an extreme edge case, but do we just ignore it or do we somehow respect it?
If this isn't important to you, i will link a quick pr.

[FallenDeity]

I do see some direct consumption from sprites repo https://github.com/search?q=brilliant-diamond-and-shining-pearl&type=code renaming it is definitely required either from api side or sprite side (sprite side seems more apt). But maybe we can leave that folder for backwards compatibility and mark it deprecated and remove it in one if the future prs so it doesn't suddenly cause impact. Maybe also add a note.

cc: @Naramsim what are your thoughts on this

[Naramsim]

Hi, I think we can go with renaming the brilliant-diamond-and-shining-pearl folder to brilliant-diamond-shining-pearl, then regenerate the API and we should have the right link. The API isn't serving them and that matters the most over people using hardcoded paths.

We could use the -and- name in the function that reads the images over at pokeapi but it's also a matter of consistency.