-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Open
Description
Problem
Disabled/shutdown servers still record trace events to database.
Proposed Solution
org.apache.shardingsphere.elasticjob.kernel.executor.facade.AbstractJobFacade#isJobEnabled
public boolean isJobEnabled() {
// Check if job is shutdown
if (JobRegistry.getInstance().isShutdown(jobName)) {
return false;
}
// Get job instance, return false if null
JobInstance jobInstance = JobRegistry.getInstance().getJobInstance(jobName);
if (null == jobInstance) {
return false;
}
// Check server status in ZooKeeper
return serverService.isEnableServer(jobInstance.getServerIp());
}
org.apache.shardingsphere.elasticjob.kernel.executor.ElasticJobExecutor#execute()
public void execute() {
JobConfiguration jobConfig = jobFacade.loadJobConfiguration(true);
executorServiceReloader.reloadIfNecessary(jobConfig);
jobErrorHandlerReloader.reloadIfNecessary(jobConfig);
JobErrorHandler jobErrorHandler = jobErrorHandlerReloader.getJobErrorHandler();
// Check if job of server is enabled before executing, skip silently if disabled
if (!jobFacade.isJobEnabled()) {
log.debug("Job '{}' is not executed because server is disabled.", jobConfig.getJobName());
return;
}
...Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels