From 97250576b364263684cfdbd3b07033bb4910acca Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Fri, 27 Feb 2026 09:18:32 +0000 Subject: [PATCH 1/2] chore(deps): update pre-commit hook python-jsonschema/check-jsonschema to v0.37.0 (#998) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --- .pre-commit-config.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index c8ea80699..2cf002bf6 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -223,7 +223,7 @@ repos: # json - repo: https://github.com/python-jsonschema/check-jsonschema - rev: 0.36.2 + rev: 0.37.0 hooks: - id: check-circle-ci - id: check-github-workflows From 25bd5cee68318f48698747b67184604b7c308934 Mon Sep 17 00:00:00 2001 From: Kevin James Date: Fri, 27 Feb 2026 13:42:49 +0000 Subject: [PATCH 2/2] test(taskqueue): clean up unnecessary fixtures --- taskqueue/tests/integration/conftest.py | 25 ---------- taskqueue/tests/integration/pushqueue_test.py | 47 +++++++++++-------- 2 files changed, 27 insertions(+), 45 deletions(-) diff --git a/taskqueue/tests/integration/conftest.py b/taskqueue/tests/integration/conftest.py index c6b3bed81..ddcc99cca 100644 --- a/taskqueue/tests/integration/conftest.py +++ b/taskqueue/tests/integration/conftest.py @@ -2,14 +2,6 @@ import os import pytest -from gcloud.aio.auth import BUILD_GCLOUD_REST # pylint: disable=no-name-in-module -from gcloud.aio.taskqueue import PushQueue - -# Selectively load libraries based on the package -if BUILD_GCLOUD_REST: - from requests import Session -else: - from aiohttp import ClientSession as Session def pytest_configure(config): @@ -37,20 +29,3 @@ def push_queue_name() -> str: @pytest.fixture(scope='module') def push_queue_location() -> str: return 'us-west2' - - -@pytest.fixture(scope='function') -async def session() -> str: - async with Session() as session: - yield session - - -@pytest.fixture(scope='function') -async def push_queue( - project, creds, push_queue_name, push_queue_location, - session, -): - return PushQueue( - project, push_queue_name, service_file=creds, - location=push_queue_location, session=session, - ) diff --git a/taskqueue/tests/integration/pushqueue_test.py b/taskqueue/tests/integration/pushqueue_test.py index 2f8d99d9f..0b9adf9ea 100644 --- a/taskqueue/tests/integration/pushqueue_test.py +++ b/taskqueue/tests/integration/pushqueue_test.py @@ -1,10 +1,13 @@ import datetime import pytest +from gcloud.aio.taskqueue import PushQueue @pytest.mark.asyncio -async def test_task_lifecycle_in_push_queue(push_queue): +async def test_task_lifecycle_in_push_queue( + project, creds, push_queue_name, push_queue_location +): # Set to run in the future, giving us enough time to test all # functionalities before the task gets dispatched automatically. schedule_time = (datetime.datetime.now(datetime.timezone.utc) @@ -20,22 +23,26 @@ async def test_task_lifecycle_in_push_queue(push_queue): }, } - # CREATE - created = await push_queue.create(task) - assert created - - try: - # GET - assert created == await push_queue.get(created['name'], full=True) - - # LIST - listed = await push_queue.list(full=True) - assert listed.get('tasks') - assert created in listed['tasks'] - - # RUN - run = await push_queue.run(created['name'], full=True) - assert all(item in run.items() for item in created.items()) - finally: - # DELETE - assert not await push_queue.delete(created['name']) + async with PushQueue( + project, push_queue_name, service_file=creds, + location=push_queue_location, + ) as push_queue: + # CREATE + created = await push_queue.create(task) + assert created + + try: + # GET + assert created == await push_queue.get(created['name'], full=True) + + # LIST + listed = await push_queue.list(full=True) + assert listed.get('tasks') + assert created in listed['tasks'] + + # RUN + run = await push_queue.run(created['name'], full=True) + assert all(item in run.items() for item in created.items()) + finally: + # DELETE + assert not await push_queue.delete(created['name'])