Skip to content

fix: Lack of epsilon aware comparison in NETopKV for Fp32 data type#1265

Open
morgolock wants to merge 1 commit intomainfrom
pr/topk_f32_mismatch
Open

fix: Lack of epsilon aware comparison in NETopKV for Fp32 data type#1265
morgolock wants to merge 1 commit intomainfrom
pr/topk_f32_mismatch

Conversation

@morgolock
Copy link
Contributor

@morgolock morgolock commented Mar 4, 2026 •
edited
Loading

Align NETopKV Fp32 comparison semantics with the scalar reference.

Resolves COMPMID-8829

Change-Id: I995a07e0f38587b69b0ac08ee2c85949704f0e60

@gunes-arm
Copy link
Contributor

gunes-arm commented Mar 4, 2026 •
edited
Loading

I can suggest a few rewordings to the commit title and description:

fix: topkv FP32 NEON comparison epsilon mismatch#1265

Lack of epsilon aware comparison in NETopKV for Fp32 data type

Align NEON FP32 TopK comparison semantics with the scalar reference by using v > threshold + epsilon instead of a raw v > threshold. Prevents rare single-value mismatches for near-threshold floats.

Align NETopKV Fp32 comparison semantics ...

@morgolock morgolock changed the title fix: topkv FP32 NEON comparison epsilon mismatch Lack of epsilon aware comparison in NETopKV for Fp32 data type Mar 4, 2026
gunes-arm
gunes-arm requested changes Mar 4, 2026
View reviewed changes
Copy link
Contributor

@gunes-arm gunes-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments regarding the commit message. The rest looks good to me.

@morgolock morgolock force-pushed the pr/topk_f32_mismatch branch from 1ea020e to e28ca9d Compare March 4, 2026 11:47
@morgolock
Copy link
Contributor Author

morgolock commented Mar 4, 2026

I can suggest a few rewordings to the commit title and description:

fix: topkv FP32 NEON comparison epsilon mismatch#1265

Lack of epsilon aware comparison in NETopKV for Fp32 data type

Align NEON FP32 TopK comparison semantics with the scalar reference by using v > threshold + epsilon instead of a raw v > threshold. Prevents rare single-value mismatches for near-threshold floats.

Align NETopKV Fp32 comparison semantics ...

Addressed

@morgolock morgolock force-pushed the pr/topk_f32_mismatch branch 3 times, most recently from c9853a3 to 5811265 Compare March 5, 2026 14:19
@morgolock
fix: Lack of epsilon aware comparison in NETopKV for Fp32 data type.
38d74fd 
Align NETopKV FP32 comparison semantics with the scalar reference

Resolves COMPMID-8829

Change-Id: I995a07e0f38587b69b0ac08ee2c85949704f0e60
Signed-off-by: Pablo Marquez Tello <pablo.tello@arm.com>
@morgolock morgolock force-pushed the pr/topk_f32_mismatch branch from 5811265 to 38d74fd Compare March 6, 2026 17:25
@morgolock morgolock changed the title Lack of epsilon aware comparison in NETopKV for Fp32 data type fix: Lack of epsilon aware comparison in NETopKV for Fp32 data type Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gunes-arm gunes-arm gunes-arm requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@morgolock @gunes-arm