Make DeepLabCut an optional dependency to fix circular dependency issue#25
Open
deruyter92 wants to merge 4 commits intomainfrom
Open
Make DeepLabCut an optional dependency to fix circular dependency issue#25deruyter92 wants to merge 4 commits intomainfrom
deruyter92 wants to merge 4 commits intomainfrom
Conversation
Collaborator
Author
|
@xiu-cs, do you think we can replace the pinned DeepLabCut version to a more flexible one, e.g. only a lowerbound? |
deruyter92
commented
Mar 11, 2026
Collaborator
Thanks! Previous I only tested the rc14 release version; other versions may also work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Make deeplabcut an optional dependency in fmpose3d to break the new circular dependency chain (deeplabcut[fmpose3d] -> fmpose3d -> deeplabcut).
This PR removes deeplabcut from core install requirements, adds it as an animals extra, updates DLC import paths to fail gracefully with clear install guidance when missing, and updates docs/tests accordingly.
Changes included:
fmpose3d[animals]installs deeplabcut.This preserves existing animal functionality when the extra is installed, while removing the hard dependency edge that caused the cycle.