Skip to content

[O2B-1549] Migrate anchored simulation passes overview model and simulation passes per lhc period overview model to use filtering model pattern#2104

Open
NarrowsProjects wants to merge 5 commits intoimprov/O2B-1548/Migrate-qcFlagTypesOverviewModel-to-use-FilteringModel-patternfrom
improv/O2B-1549/Migrate-AnchoredSimulationPassesOverviewModel-and-SimulationPassesPerLhcPeriodOverviewModel-to-use-FilteringModel-pattern
Open

[O2B-1549] Migrate anchored simulation passes overview model and simulation passes per lhc period overview model to use filtering model pattern#2104
NarrowsProjects wants to merge 5 commits intoimprov/O2B-1548/Migrate-qcFlagTypesOverviewModel-to-use-FilteringModel-patternfrom
improv/O2B-1549/Migrate-AnchoredSimulationPassesOverviewModel-and-SimulationPassesPerLhcPeriodOverviewModel-to-use-FilteringModel-pattern

Conversation

@NarrowsProjects
Copy link
Collaborator

@NarrowsProjects NarrowsProjects commented Mar 10, 2026

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • N/A

Notable changes for developers:

  • The AnchoredSimulationPasses and SimulationPassesPerLhcPeriod overview models now store their filter in a FilteringModel instance.
  • The names filter must now be accessed through the FilteringModel.get function

Changes made to the database:

  • N/A

@NarrowsProjects NarrowsProjects self-assigned this Mar 10, 2026
@NarrowsProjects NarrowsProjects added frontend javascript Pull requests that update Javascript code labels Mar 10, 2026
…-FilteringModel-pattern' into improv/O2B-1549/Migrate-AnchoredSimulationPassesOverviewModel-and-SimulationPassesPerLhcPeriodOverviewModel-to-use-FilteringModel-pattern
@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.85%. Comparing base (a9a1cd9) to head (f9c1adb).

Files with missing lines Patch % Lines
...dOverview/AnchoredSimulationPassesOverviewModel.js 0.00% 11 Missing ⚠️
...rview/SimulationPassesPerLhcPeriodOverviewModel.js 0.00% 11 Missing ⚠️
...ses/ActiveColumns/simulationPassesActiveColumns.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                                                Coverage Diff                                                 @@
##           improv/O2B-1548/Migrate-qcFlagTypesOverviewModel-to-use-FilteringModel-pattern    #2104      +/-   ##
==================================================================================================================
+ Coverage                                                                           45.66%   45.85%   +0.18%     
==================================================================================================================
  Files                                                                                1042     1042              
  Lines                                                                               17173    17169       -4     
  Branches                                                                             3103     3103              
==================================================================================================================
+ Hits                                                                                 7842     7872      +30     
+ Misses                                                                               9331     9297      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

1 participant