Skip to content

[O2B-1562] Replace all instances of text filter with raw text filter#2111

Open
NarrowsProjects wants to merge 5 commits intoimprov/O2B-1534/Migrate-Log-Overview-to-use-FilteringModel-patternfrom
improv/O2B-1562/Replace-all-instances-of-textFilter-with-rawTextFilter
Open

[O2B-1562] Replace all instances of text filter with raw text filter#2111
NarrowsProjects wants to merge 5 commits intoimprov/O2B-1534/Migrate-Log-Overview-to-use-FilteringModel-patternfrom
improv/O2B-1562/Replace-all-instances-of-textFilter-with-rawTextFilter

Conversation

@NarrowsProjects
Copy link
Collaborator

@NarrowsProjects NarrowsProjects commented Mar 12, 2026

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • When typing in the input filters for Logs, LHC periods and Anchored passes the filters will be applied after leaving the input rather than after every key press

Notable changes for developers:

  • the textFiltercomponent doesn't exist anymore
  • The textTokensFilterModel now uses the name 'value' over 'raw' for it's primary instance variable

Changes made to the database:

  • N/A

@NarrowsProjects NarrowsProjects self-assigned this Mar 12, 2026
@NarrowsProjects NarrowsProjects added frontend javascript Pull requests that update Javascript code labels Mar 12, 2026
@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.86%. Comparing base (237683a) to head (604a2af).

Files with missing lines Patch % Lines
...hcPeriods/ActiveColumns/lhcPeriodsActiveColumns.js 0.00% 4 Missing ⚠️
...lagTypes/ActiveColumns/qcFlagTypesActiveColumns.js 0.00% 2 Missing ⚠️
...ts/Filters/common/filters/TextTokensFilterModel.js 0.00% 1 Missing ⚠️
...ses/ActiveColumns/simulationPassesActiveColumns.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                                          Coverage Diff                                           @@
##           improv/O2B-1534/Migrate-Log-Overview-to-use-FilteringModel-pattern    #2111      +/-   ##
======================================================================================================
+ Coverage                                                               45.82%   45.86%   +0.04%     
======================================================================================================
  Files                                                                    1041     1040       -1     
  Lines                                                                   17180    17164      -16     
  Branches                                                                 3106     3104       -2     
======================================================================================================
  Hits                                                                     7872     7872              
+ Misses                                                                   9308     9292      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NarrowsProjects NarrowsProjects changed the title Improv/o2 b 1562/replace all instances of text filter with raw text filter [O2B-1562] Replace all instances of text filter with raw text filter Mar 12, 2026
@NarrowsProjects NarrowsProjects force-pushed the improv/O2B-1562/Replace-all-instances-of-textFilter-with-rawTextFilter branch from b0c1a87 to 604a2af Compare March 12, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

1 participant