[PWGJE] Add new D0 substructure task#15311
[PWGJE] Add new D0 substructure task#15311pdhankhe wants to merge 6 commits intoAliceO2Group:masterfrom
Conversation
pdhankhe
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern,
nzardosh and
raymondEhlers
as code owners
github-actions
bot
changed the title
Please consider the following formatting changes to AliceO2Group#15311
PWGJE/Tasks/jetD0Substructure.cxx
Outdated
| angularity /= (jet.pt() * (jet.r() / 100.f)); | ||
| } | ||
| // Collision-level and for Tracks QA | ||
| void processCollisions(aod::JetCollision const& collision, aod::JetTracks const& tracks) |
There was a problem hiding this comment.
why do you do these in a seperate process function?
There was a problem hiding this comment.
I had some QA functions but now I have removed them.
PWGJE/Tasks/CMakeLists.txt
Outdated
| SOURCES jetDsSpectrumAndSubstructure.cxx | ||
| PUBLIC_LINK_LIBRARIES O2::Framework O2Physics::PWGJECore O2Physics::AnalysisCore | ||
| COMPONENT_NAME Analysis) | ||
| o2physics_add_dpl_workflow(jet-d0-substructure |
There was a problem hiding this comment.
the name is quite similair to the other D0 substructure task so please consider something different
There was a problem hiding this comment.
I have now renamed to avoid any confusions.
PWGJE/Tasks/jetD0Substructure.cxx
Outdated
| } | ||
| angularity += std::pow(constituent.pt(), kappa) * std::pow(jetutilities::deltaR(jet, constituent), alpha); | ||
| } | ||
| angularity /= (jet.pt() * (jet.r() / 100.f)); |
There was a problem hiding this comment.
you havent included kappa and alpha in the denominator
There was a problem hiding this comment.
Thanks for catching this. I was only running with k = 1 and B = 1, so it didn’t matter in that case. I’ve now fixed it so that the other angularities are computed correctly.
| } | ||
| PROCESS_SWITCH(JetD0Substructure, processDataCharged, "charged jets in data", false); | ||
|
|
||
| void processDataChargedSubstructure(aod::JetCollision const& collision, |
There was a problem hiding this comment.
Do you not here also want to apply the JetFilter and EventFilter like you do for processDataCharged with soa::Filtered?
There was a problem hiding this comment.
Removed other functions and currently I will prefer to use the version I have in processDataChargedSubstructure.
| jet.pt(), jet.eta(), jet.phi(), jet.tracks_as<aod::JetTracks>().size(), angularity, | ||
| d0Candidate.pt(), d0Candidate.eta(), d0Candidate.phi(), d0Candidate.m(), d0Candidate.y(), d0Candidate.mlScores()[0], d0Candidate.mlScores()[1], d0Candidate.mlScores()[2]); | ||
|
|
||
| break; // get out of candidates' loop after first HF particle is found in jet |
There was a problem hiding this comment.
I am not an HF-jet expert, but is it desired that one breaks after the first candidate that one finds as part of the jet? Are the d0Candidates somehow or is the order random?
There was a problem hiding this comment.
there should ever only be one in the current code anyways
PWGJE/Tasks/jetD0Substructure.cxx
Outdated
| {"h_d0_jet_eta", ";#eta_{T,D^{0} jet};dN/d#eta_{D^{0} jet}", {HistType::kTH1F, {{250, -5., 5.}}}}, | ||
| {"h_d0_jet_phi", ";#phi_{T,D^{0} jet};dN/d#phi_{D^{0} jet}", {HistType::kTH1F, {{250, -10., 10.}}}}, | ||
| {"h_d0_mass", ";m_{D^{0}} (GeV/c^{2});dN/dm_{D^{0}}", {HistType::kTH1F, {{1000, 0., 10.}}}}, | ||
| {"h_d0_eta", ";#eta_{D^{0}} (GeV/c^{2});dN/d#eta_{D_{}}", {HistType::kTH1F, {{250, -5., 5.}}}}, |
There was a problem hiding this comment.
eta is not unit GeV/c^2
PWGJE/Tasks/jetD0Substructure.cxx
Outdated
| {"h_d0_jet_phi", ";#phi_{T,D^{0} jet};dN/d#phi_{D^{0} jet}", {HistType::kTH1F, {{250, -10., 10.}}}}, | ||
| {"h_d0_mass", ";m_{D^{0}} (GeV/c^{2});dN/dm_{D^{0}}", {HistType::kTH1F, {{1000, 0., 10.}}}}, | ||
| {"h_d0_eta", ";#eta_{D^{0}} (GeV/c^{2});dN/d#eta_{D_{}}", {HistType::kTH1F, {{250, -5., 5.}}}}, | ||
| {"h_d0_phi", ";#phi_{D^{0}} (GeV/c^{2});dN/d#phi_{D^{0}}", {HistType::kTH1F, {{250, -10., 10.}}}}, |
There was a problem hiding this comment.
same comment as above
PWGJE/Tasks/jetD0Substructure.cxx
Outdated
| Produces<aod::JetObjTable> ObjJetTable; | ||
|
|
||
| float angularity; | ||
| float leadingConstituentPt; |
There was a problem hiding this comment.
unused variable (calculated but never used)
There was a problem hiding this comment.
I’m using angularity and ObjJetTable in the processDataChargedSubstructure function, but I removed leadingConstituentPt which wasn’t used.
Please consider the following formatting changes to AliceO2Group#15311
4 participants
Adding a new D0 substructure task.