Optionally use context swap on akka and pekko#10778
Optionally use context swap on akka and pekko#10778gh-worker-dd-mergequeue-cf854d[bot] merged 15 commits intomasterfrom
Conversation
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
PerfectSlayer
left a comment
There was a problem hiding this comment.
Looking good.
🎯 suggestion: I would recommend using the return value for the "checkpointed" context and only keep the legacy task scope as local var, not the two as local vars. It should be easier to clean it later when we will drop the task scope.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~b58d8f98ca, baseline=1.61.0-SNAPSHOT~10d731c967
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056407
Total [baseline] (8.829 s) : 0, 8829174
Agent [candidate] (1.055 s) : 0, 1055266
Total [candidate] (8.828 s) : 0, 8828267
section iast
Agent [baseline] (1.228 s) : 0, 1227719
Total [baseline] (9.519 s) : 0, 9518711
Agent [candidate] (1.226 s) : 0, 1225980
Total [candidate] (9.536 s) : 0, 9536370
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~b58d8f98ca, baseline=1.61.0-SNAPSHOT~10d731c967
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (628.167 ms) : 0, 628167
BytebuddyAgent [candidate] (626.769 ms) : 0, 626769
AgentMeter [baseline] (29.034 ms) : 0, 29034
AgentMeter [candidate] (28.993 ms) : 0, 28993
GlobalTracer [baseline] (256.655 ms) : 0, 256655
GlobalTracer [candidate] (255.949 ms) : 0, 255949
AppSec [baseline] (31.557 ms) : 0, 31557
AppSec [candidate] (31.499 ms) : 0, 31499
Debugger [baseline] (58.69 ms) : 0, 58690
Debugger [candidate] (58.531 ms) : 0, 58531
Remote Config [baseline] (588.43 µs) : 0, 588
Remote Config [candidate] (603.301 µs) : 0, 603
Telemetry [baseline] (8.771 ms) : 0, 8771
Telemetry [candidate] (8.626 ms) : 0, 8626
Flare Poller [baseline] (5.645 ms) : 0, 5645
Flare Poller [candidate] (7.132 ms) : 0, 7132
section iast
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (797.178 ms) : 0, 797178
BytebuddyAgent [candidate] (796.154 ms) : 0, 796154
AgentMeter [baseline] (11.32 ms) : 0, 11320
AgentMeter [candidate] (11.312 ms) : 0, 11312
GlobalTracer [baseline] (247.491 ms) : 0, 247491
GlobalTracer [candidate] (247.233 ms) : 0, 247233
IAST [baseline] (25.143 ms) : 0, 25143
IAST [candidate] (25.075 ms) : 0, 25075
AppSec [baseline] (26.404 ms) : 0, 26404
AppSec [candidate] (27.109 ms) : 0, 27109
Debugger [baseline] (62.634 ms) : 0, 62634
Debugger [candidate] (61.782 ms) : 0, 61782
Remote Config [baseline] (536.084 µs) : 0, 536
Remote Config [candidate] (525.903 µs) : 0, 526
Telemetry [baseline] (14.88 ms) : 0, 14880
Telemetry [candidate] (15.116 ms) : 0, 15116
Flare Poller [baseline] (4.692 ms) : 0, 4692
Flare Poller [candidate] (4.538 ms) : 0, 4538
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~b58d8f98ca, baseline=1.61.0-SNAPSHOT~10d731c967
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1058822
Total [baseline] (10.92 s) : 0, 10920097
Agent [candidate] (1.063 s) : 0, 1062528
Total [candidate] (11.034 s) : 0, 11033695
section appsec
Agent [baseline] (1.242 s) : 0, 1242053
Total [baseline] (11.084 s) : 0, 11083639
Agent [candidate] (1.246 s) : 0, 1246388
Total [candidate] (11.098 s) : 0, 11098249
section iast
Agent [baseline] (1.227 s) : 0, 1227448
Total [baseline] (11.301 s) : 0, 11301253
Agent [candidate] (1.231 s) : 0, 1231379
Total [candidate] (11.226 s) : 0, 11225522
section profiling
Agent [baseline] (1.179 s) : 0, 1178676
Total [baseline] (11.055 s) : 0, 11055329
Agent [candidate] (1.187 s) : 0, 1187311
Total [candidate] (11.004 s) : 0, 11003946
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~b58d8f98ca, baseline=1.61.0-SNAPSHOT~10d731c967
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (627.91 ms) : 0, 627910
BytebuddyAgent [candidate] (631.64 ms) : 0, 631640
AgentMeter [baseline] (29.062 ms) : 0, 29062
AgentMeter [candidate] (29.262 ms) : 0, 29262
GlobalTracer [baseline] (256.488 ms) : 0, 256488
GlobalTracer [candidate] (257.946 ms) : 0, 257946
AppSec [baseline] (31.552 ms) : 0, 31552
AppSec [candidate] (31.811 ms) : 0, 31811
Debugger [baseline] (59.365 ms) : 0, 59365
Debugger [candidate] (59.698 ms) : 0, 59698
Remote Config [baseline] (584.096 µs) : 0, 584
Remote Config [candidate] (587.397 µs) : 0, 587
Telemetry [baseline] (8.638 ms) : 0, 8638
Telemetry [candidate] (8.633 ms) : 0, 8633
Flare Poller [baseline] (7.963 ms) : 0, 7963
Flare Poller [candidate] (5.703 ms) : 0, 5703
section appsec
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (655.459 ms) : 0, 655459
BytebuddyAgent [candidate] (658.201 ms) : 0, 658201
AgentMeter [baseline] (12.015 ms) : 0, 12015
AgentMeter [candidate] (12.09 ms) : 0, 12090
GlobalTracer [baseline] (257.68 ms) : 0, 257680
GlobalTracer [candidate] (258.208 ms) : 0, 258208
IAST [baseline] (23.872 ms) : 0, 23872
IAST [candidate] (23.89 ms) : 0, 23890
AppSec [baseline] (177.067 ms) : 0, 177067
AppSec [candidate] (177.769 ms) : 0, 177769
Debugger [baseline] (65.233 ms) : 0, 65233
Debugger [candidate] (65.692 ms) : 0, 65692
Remote Config [baseline] (573.627 µs) : 0, 574
Remote Config [candidate] (578.004 µs) : 0, 578
Telemetry [baseline] (9.081 ms) : 0, 9081
Telemetry [candidate] (8.906 ms) : 0, 8906
Flare Poller [baseline] (3.592 ms) : 0, 3592
Flare Poller [candidate] (3.59 ms) : 0, 3590
section iast
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (796.193 ms) : 0, 796193
BytebuddyAgent [candidate] (800.519 ms) : 0, 800519
AgentMeter [baseline] (11.328 ms) : 0, 11328
AgentMeter [candidate] (11.327 ms) : 0, 11327
GlobalTracer [baseline] (247.485 ms) : 0, 247485
GlobalTracer [candidate] (247.43 ms) : 0, 247430
IAST [baseline] (25.154 ms) : 0, 25154
IAST [candidate] (25.102 ms) : 0, 25102
AppSec [baseline] (26.391 ms) : 0, 26391
AppSec [candidate] (26.35 ms) : 0, 26350
Debugger [baseline] (63.491 ms) : 0, 63491
Debugger [candidate] (63.196 ms) : 0, 63196
Remote Config [baseline] (538.692 µs) : 0, 539
Remote Config [candidate] (523.415 µs) : 0, 523
Telemetry [baseline] (15.368 ms) : 0, 15368
Telemetry [candidate] (14.877 ms) : 0, 14877
Flare Poller [baseline] (4.262 ms) : 0, 4262
Flare Poller [candidate] (4.391 ms) : 0, 4391
section profiling
crashtracking [baseline] (1.158 ms) : 0, 1158
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (680.221 ms) : 0, 680221
BytebuddyAgent [candidate] (685.945 ms) : 0, 685945
AgentMeter [baseline] (8.54 ms) : 0, 8540
AgentMeter [candidate] (8.638 ms) : 0, 8638
GlobalTracer [baseline] (214.718 ms) : 0, 214718
GlobalTracer [candidate] (216.7 ms) : 0, 216700
AppSec [baseline] (31.78 ms) : 0, 31780
AppSec [candidate] (32.176 ms) : 0, 32176
Debugger [baseline] (62.909 ms) : 0, 62909
Debugger [candidate] (62.983 ms) : 0, 62983
Remote Config [baseline] (593.404 µs) : 0, 593
Remote Config [candidate] (576.045 µs) : 0, 576
Telemetry [baseline] (10.577 ms) : 0, 10577
Telemetry [candidate] (10.538 ms) : 0, 10538
Flare Poller [baseline] (3.503 ms) : 0, 3503
Flare Poller [candidate] (3.544 ms) : 0, 3544
ProfilingAgent [baseline] (94.015 ms) : 0, 94015
ProfilingAgent [candidate] (94.003 ms) : 0, 94003
Profiling [baseline] (94.587 ms) : 0, 94587
Profiling [candidate] (94.561 ms) : 0, 94561
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~b58d8f98ca, baseline=1.61.0-SNAPSHOT~10d731c967
dateFormat X
axisFormat %s
section baseline
no_agent (18.866 ms) : 18671, 19061
. : milestone, 18866,
appsec (18.486 ms) : 18298, 18673
. : milestone, 18486,
code_origins (17.888 ms) : 17713, 18062
. : milestone, 17888,
iast (18.554 ms) : 18361, 18746
. : milestone, 18554,
profiling (18.636 ms) : 18453, 18819
. : milestone, 18636,
tracing (18.044 ms) : 17864, 18223
. : milestone, 18044,
section candidate
no_agent (18.178 ms) : 17991, 18364
. : milestone, 18178,
appsec (18.427 ms) : 18237, 18616
. : milestone, 18427,
code_origins (18.26 ms) : 18076, 18444
. : milestone, 18260,
iast (17.565 ms) : 17390, 17740
. : milestone, 17565,
profiling (18.974 ms) : 18785, 19164
. : milestone, 18974,
tracing (17.727 ms) : 17552, 17902
. : milestone, 17727,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~b58d8f98ca, baseline=1.61.0-SNAPSHOT~10d731c967
dateFormat X
axisFormat %s
section baseline
no_agent (1.189 ms) : 1177, 1200
. : milestone, 1189,
iast (3.243 ms) : 3200, 3286
. : milestone, 3243,
iast_FULL (5.781 ms) : 5724, 5838
. : milestone, 5781,
iast_GLOBAL (3.622 ms) : 3563, 3681
. : milestone, 3622,
profiling (2.193 ms) : 2170, 2215
. : milestone, 2193,
tracing (1.788 ms) : 1773, 1804
. : milestone, 1788,
section candidate
no_agent (1.213 ms) : 1200, 1225
. : milestone, 1213,
iast (3.241 ms) : 3195, 3287
. : milestone, 3241,
iast_FULL (5.798 ms) : 5741, 5855
. : milestone, 5798,
iast_GLOBAL (3.623 ms) : 3556, 3689
. : milestone, 3623,
profiling (2.222 ms) : 2201, 2243
. : milestone, 2222,
tracing (1.752 ms) : 1738, 1766
. : milestone, 1752,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~b58d8f98ca, baseline=1.61.0-SNAPSHOT~10d731c967
dateFormat X
axisFormat %s
section baseline
no_agent (14.969 s) : 14969000, 14969000
. : milestone, 14969000,
appsec (15.054 s) : 15054000, 15054000
. : milestone, 15054000,
iast (18.408 s) : 18408000, 18408000
. : milestone, 18408000,
iast_GLOBAL (17.782 s) : 17782000, 17782000
. : milestone, 17782000,
profiling (14.515 s) : 14515000, 14515000
. : milestone, 14515000,
tracing (15.27 s) : 15270000, 15270000
. : milestone, 15270000,
section candidate
no_agent (15.706 s) : 15706000, 15706000
. : milestone, 15706000,
appsec (14.805 s) : 14805000, 14805000
. : milestone, 14805000,
iast (17.774 s) : 17774000, 17774000
. : milestone, 17774000,
iast_GLOBAL (17.898 s) : 17898000, 17898000
. : milestone, 17898000,
profiling (15.155 s) : 15155000, 15155000
. : milestone, 15155000,
tracing (15.031 s) : 15031000, 15031000
. : milestone, 15031000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~b58d8f98ca, baseline=1.61.0-SNAPSHOT~10d731c967
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (3.823 ms) : 3600, 4046
. : milestone, 3823,
iast (2.263 ms) : 2194, 2332
. : milestone, 2263,
iast_GLOBAL (2.299 ms) : 2230, 2368
. : milestone, 2299,
profiling (2.102 ms) : 2047, 2157
. : milestone, 2102,
tracing (2.073 ms) : 2020, 2126
. : milestone, 2073,
section candidate
no_agent (1.483 ms) : 1471, 1494
. : milestone, 1483,
appsec (3.792 ms) : 3570, 4013
. : milestone, 3792,
iast (2.274 ms) : 2205, 2343
. : milestone, 2274,
iast_GLOBAL (2.301 ms) : 2232, 2370
. : milestone, 2301,
profiling (2.505 ms) : 2340, 2669
. : milestone, 2505,
tracing (2.089 ms) : 2035, 2143
. : milestone, 2089,
|
...rc/main/java/datadog/trace/instrumentation/akka/concurrent/AkkaActorCellInstrumentation.java
Outdated
Show resolved
Hide resolved
.../main/java/datadog/trace/instrumentation/pekko/concurrent/PekkoActorCellInstrumentation.java
Outdated
Show resolved
Hide resolved
mcculls
left a comment
There was a problem hiding this comment.
Minor recommendation to avoid extra @Advice.Local and use @Advice.Enter instead
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
ec4badf to
d371790
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Uses context swap instead of checkpoint/rollback when legacy context manager is disabled
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.