Skip to content

[TEST] Demo changes for incorporate-pr-feedback skill#35261

Draft
buraizu wants to merge 1 commit intomasterfrom
bryce/incorporate-pr-feedback-demo
Draft

[TEST] Demo changes for incorporate-pr-feedback skill#35261
buraizu wants to merge 1 commit intomasterfrom
bryce/incorporate-pr-feedback-demo

Conversation

@buraizu
Copy link
Contributor

@buraizu buraizu commented Mar 12, 2026

What does this PR do? What is the motivation?

TEST BRANCH — for demonstrating the incorporate-pr-feedback skill. Do not merge.

Updates the Getting Started with AWS integration guide with several changes:

  • Rewrites the Overview to be more descriptive
  • Expands the Prerequisites section with a note about console access
  • Adds guidance on choosing a log forwarding method
  • Adds a new Tag filtering section under Configuration

Merge instructions

Merge readiness:

  • Ready for merge

Additional notes

This PR is intentionally written with style issues to demonstrate the incorporate-pr-feedback skill's ability to process and apply reviewer comments.

@buraizu buraizu requested a review from a team as a code owner March 12, 2026 23:42
Copy link
Contributor Author

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I've left a few comments on specific lines. Some of these are Vale violations that our linter will catch, and a couple are content/style concerns.


## Overview

This guide walks you through integrating an Amazon Web Services (AWS) account with Datadog using Datadog's CloudFormation template. After completing setup, you can enable individual AWS service integrations, install the Datadog Agent on EC2 instances for deeper visibility, and configure log forwarding.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vale: 'will walk' uses a temporal word ('will'). Revert to present tense: "This guide walks you through..."


## Overview

This guide walks you through integrating an Amazon Web Services (AWS) account with Datadog using Datadog's CloudFormation template. After completing setup, you can enable individual AWS service integrations, install the Datadog Agent on EC2 instances for deeper visibility, and configure log forwarding.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vale: 'Once you have completed setup' — use 'After you complete setup' instead. Also, 'easily' should be removed (Vale: words to avoid).

Copy link
Contributor Author

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left several inline comments covering Vale violations and content concerns. These demonstrate the kinds of issues incorporate-pr-feedback can help apply.


## Overview

This guide walks you through integrating an Amazon Web Services (AWS) account with Datadog using Datadog's CloudFormation template. After completing setup, you can enable individual AWS service integrations, install the Datadog Agent on EC2 instances for deeper visibility, and configure log forwarding.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vale: 'will walk' uses a temporal word. Switch to present tense: "This guide walks you through..."

Also, 'Once you have completed setup' → 'After you complete setup' (Vale: use 'After' instead of 'Once').

Also, remove 'easily' — it's a filler word per the style guide.

Also, 'to ensure that all your data is collected' — 'ensure' should be avoided or replaced with 'helps ensure'. Consider simplifying: end the sentence at 'configure log forwarding.'

This guide will walk you through the process of integrating an Amazon Web Services (AWS) account with Datadog using Datadog's CloudFormation template. Once you have completed setup, you can easily enable individual AWS service integrations, install the Datadog Agent on EC2 instances for deeper visibility, and configure log forwarding to ensure that all your data is collected.

## Prerequisites

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vale: 'Note that' should be replaced with 'Note:' per the Datadog style guide.

Also, the additional clause 'and administrative access to your AWS console' is useful context — keep it.

@@ -130,15 +130,21 @@ Use the **Metric Collection** tab on the [AWS integration page][8] to configure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content: The 'Tag filtering' section uses several flagged phrases:

  • 'leverage' → use 'use'
  • 'utilizing' → use 'using'
  • 'easily' → remove
  • 'fine-tune' → use 'customize'

Suggested rewrite: "Use tag-based filtering to control which AWS resources Datadog monitors. Under the Metric Collection tab, add tag filters to include or exclude specific resources and customize your monitoring scope."


## Send logs

There are two ways to send AWS service logs to Datadog:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vale: 'simplest' — avoid superlatives like 'simplest'. Consider: 'This option requires no additional infrastructure.'


- [Amazon Data Firehose destination][10]: Recommended for high-volume CloudWatch logs.
- [Amazon Data Firehose destination][10]: Recommended for high-volume CloudWatch logs. This is the simplest option and requires no additional infrastructure.
- [Forwarder Lambda function][11]: Required for traces, enhanced metrics, or custom metrics from Lambda functions. Also recommended for logs from S3 or other resources that cannot stream directly to Amazon Data Firehose.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vale + Style: Multiple issues in this tip:

  • 'currently' is a temporal word — remove it
  • 'easier to set up' — avoid comparatives like 'easier'; be specific instead
  • The tip format ('Tip:') is non-standard for this doc site — use a 'Note:' callout or incorporate the guidance into the bullet list above instead.

@github-actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@buraizu buraizu added the Do Not Merge Just do not merge this PR :) label Mar 12, 2026
@buraizu buraizu marked this pull request as draft March 12, 2026 23:47
## Overview

This guide walks you through integrating an Amazon Web Services (AWS) account with Datadog using Datadog's CloudFormation template. After completing setup, you can enable individual AWS service integrations, install the Datadog Agent on EC2 instances for deeper visibility, and configure log forwarding.
This guide will walk you through the process of integrating an Amazon Web Services (AWS) account with Datadog using Datadog's CloudFormation template. Once you have completed setup, you can easily enable individual AWS service integrations, install the Datadog Agent on EC2 instances for deeper visibility, and configure log forwarding to ensure that all your data is collected.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vale (multiple): Several issues on this line:

  1. 'will walk' uses a temporal word ('will'). Revert to present tense: 'This guide walks you through...'
  2. 'Once you have completed setup' → 'After you complete setup' ('Once' is flagged; use 'After')
  3. Remove 'easily' — filler word per the Datadog style guide
  4. 'to ensure that all your data is collected' — remove; it's redundant padding. End the sentence at 'configure log forwarding.'

Suggested rewrite: 'This guide walks you through integrating an Amazon Web Services (AWS) account with Datadog using Datadog's CloudFormation template. After completing setup, you can enable individual AWS service integrations, install the Datadog Agent on EC2 instances for deeper visibility, and configure log forwarding.'

## Prerequisites

Before you begin, ensure that you have an [AWS][7] account. The CloudFormation template creates an IAM role and associated policy, allowing Datadog's AWS account to make API calls to your AWS account to collect and push data. Your AWS user must have the following IAM permissions to run the template:
Before you begin, ensure you have an [AWS][7] account and administrative access to your AWS console. The CloudFormation template creates an IAM role and associated policy, allowing Datadog's AWS account to make API calls to your AWS account to collect and push data. Note that your AWS user must have the following IAM permissions to run the template:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vale: 'Note that' should be replaced with 'Note:' — this is a direct Vale violation per the Datadog style guide.

Change to: 'Note: Your AWS user must have the following IAM permissions to run the template:'

Under the **General** tab on the [AWS integration page][8], you can control the AWS regions where Datadog collects metrics, CloudWatch events, and resources.

### Tag filtering

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vale (multiple): The new 'Tag filtering' section has several style guide violations:

  1. 'leverage' → 'use'
  2. 'utilizing' → 'using'
  3. 'easily' → remove
  4. 'fine-tune' → 'customize'

Suggested rewrite:

'Use tag-based filtering to control which AWS resources Datadog monitors. Add tag filters under the Metric Collection tab to include or exclude specific resources and customize your monitoring scope.'

You can leverage tag-based filtering to control which AWS resources Datadog monitors. By utilizing tag filters under the **Metric Collection** tab, you can easily include or exclude specific resources. This allows you to fine-tune your monitoring setup to only collect metrics from the resources that matter to your team.

## Send logs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style: 'simplest' is a superlative that implies ease — avoid these per the style guide. Change to something more factual: 'This option requires no additional infrastructure.'


See [Enable logging for your AWS service][14] for setup instructions.

**Tip**: If you are currently unsure which method to use, start with the Amazon Data Firehose destination, as it is easier to set up and maintain.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vale + Structure: Several issues with this tip:

  1. 'currently' is a temporal word — remove it ('If you are unsure which method to use...')
  2. 'easier' is a comparative that implies simplicity — be specific instead (e.g., 'requires less configuration')
  3. 'Tip:' is a non-standard callout format for this site. Either use 'Note:' or fold this guidance into the bullet list above as a note on the Firehose option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Merge Just do not merge this PR :)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant