Skip to content

chore: Add design system audit report (#6606)#6806

Draft
talissoncosta wants to merge 11 commits intomainfrom
chore/design-system-audit-6606
Draft

chore: Add design system audit report (#6606)#6806
talissoncosta wants to merge 11 commits intomainfrom
chore/design-system-audit-6606

Conversation

@talissoncosta
Copy link
Contributor

Summary

  • Adds frontend/DESIGN_SYSTEM_AUDIT.md — a comprehensive code-first audit of the frontend design system
  • Adds frontend/DESIGN_SYSTEM_AUDIT_PLAN.md — the plan document for the audit approach
  • No code changes — report only

The audit identifies 85 findings (21 P0, 34 P1, 30 P2) across 7 areas:

Area P0 P1 P2
Colours 10 11 6
Typography 2 10 8
Spacing 0 10 7
Buttons 3 2 3
Form inputs 1 3 4
Icons 4 2 1
Notifications 3 2 2

Plus a component inventory covering 11 UI pattern categories (modals, dropdowns, selects, toasts, tables, tabs, buttons, icons, empty states, tooltips, layout).

Top 5 fixes by impact:

  1. Icon.tsx default fills — ~60 icons invisible in dark mode
  2. Feature pipeline status — broken in dark mode
  3. Chart components — hardcoded light-mode colours
  4. Button variants missing dark mode (btn-tertiary, btn-danger, btn--transparent)
  5. Toast notifications — no dark mode styles

Closes #6606

Test plan

  • Review the audit report for accuracy
  • Verify file paths and line numbers are correct
  • Confirm severity classifications are appropriate

🤖 Generated with Claude Code

@talissoncosta talissoncosta requested a review from a team as a code owner February 28, 2026 02:59
@talissoncosta talissoncosta requested review from kyle-ssg and removed request for a team February 28, 2026 02:59
@vercel
Copy link

vercel bot commented Feb 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Mar 9, 2026 10:09pm
flagsmith-frontend-staging Ready Ready Preview, Comment Mar 9, 2026 10:09pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Mar 9, 2026 10:09pm

Request Review

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard chore labels Feb 28, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-6806 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6806 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6806 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6806 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-6806 Finished ✅ Results

talissoncosta and others added 9 commits March 5, 2026 11:19
Scan the frontend codebase for design token misuse, dark mode gaps,
and component fragmentation. Produces a structured report with 85
findings across 7 areas (colours, typography, spacing, buttons, forms,
icons, notifications) and a component inventory covering 11 categories.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Update DESIGN_SYSTEM_AUDIT_PLAN.md: add visual inventory as Phase 1,
  restructure into 3 phases, mark Phase 2 as in review
- Add DESIGN_SYSTEM_INVENTORY_GUIDE.md: practical guide for the
  Penpot-based interface inventory, scoped to page screenshots and
  component grouping (no interactive states or responsive breakpoints)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tion

Add Storybook with webpack5/SWC, dark mode toggle in toolbar,
SCSS support, and path aliases matching the project webpack config.

Part of #6606

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Define 60+ semantic tokens (text, surface, icon, stroke, brand, feedback,
interactive, border-radius) on :root with dark mode overrides on
[data-bs-theme='dark']. Expose as TypeScript exports for component usage.

Part of #6606

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add stories for icons, colours, colour palette, buttons, dark mode
issues, and typography — each highlighting inconsistencies and
proposed improvements from the audit.

Part of #6606

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Categorised as quick wins (QW-1 to QW-8), medium efforts (ME-1 to
ME-10), and long refactors (LR-1 to LR-8). Each template includes
problem description, affected files, and acceptance criteria.

Part of #6606

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Part of #6606

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Updates QW-1 to reflect expanded scope in PR #6870 (57 fills, not 41).
Adds PR links and scope changes to QW-4, QW-5, QW-8, QW-10.
Creates missing issue files for LR-1 through LR-9, ME-9, ME-11.
Adds audit verification report and compliance audit summary.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Restructure DESIGN_SYSTEM_ISSUES.md: QW issues with GitHub links,
  ME findings for evaluation, new patterns (NP) for incremental adoption
- Reclassify items: ME-1 → NP-3, ME-3 → NP-10, ME-4 → NP-7,
  ME-10 → NP-8, ME-11 deferred to Tailwind
- Add report draft posted as comment on #6606
- Update QW-7 to POC/spike format
- Clean up Tailwind references from issue files
- Add storybook-static/ to .gitignore

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Publishes Storybook to Chromatic on frontend PRs for easy preview.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions bot removed the chore label Mar 9, 2026
@github-actions github-actions bot added the chore label Mar 9, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.34%. Comparing base (8bc089f) to head (73f0e85).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6806   +/-   ##
=======================================
  Coverage   98.33%   98.34%           
=======================================
  Files        1336     1335    -1     
  Lines       49629    49707   +78     
=======================================
+ Hits        48804    48882   +78     
  Misses        825      825           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit frontend UI — identify inconsistencies and consolidation opportunities

1 participant