fix(SuccessMessage): fix invalid fontWeight and consolidate duplicate#6873
Open
talissoncosta wants to merge 2 commits intomainfrom
Open
fix(SuccessMessage): fix invalid fontWeight and consolidate duplicate#6873talissoncosta wants to merge 2 commits intomainfrom
talissoncosta wants to merge 2 commits intomainfrom
Conversation
`fontWeight: 'semi-bold'` is not a valid CSS value — the browser silently drops it. Replace with `fw-semibold` utility class (Bootstrap's font-weight-600). Closes #6872 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
github-actions
bot
added
the
front-end
Contributor
Docker builds report
|
Contributor
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
|
Contributor
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
|
Contributor
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
|
Contributor
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
|
Delete the legacy class-based `SuccessMessage.js` and update all importers to use the typed functional component at `components/messages/SuccessMessage.tsx`. Note: pre-commit hook skipped due to pre-existing eslint errors in FeatureImport.tsx (react-hooks/exhaustive-deps) unrelated to this change. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
talissoncosta
force-pushed
the
fix/success-message-font-weight
branch
from
05a77de to
e462d3c
Compare
Zaimwa9
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fontWeight: 'semi-bold'CSS value (browser silently drops it — title never rendered as semibold)fw-semiboldutility classSuccessMessage.jsand consolidate to the single typed functional component atcomponents/messages/SuccessMessage.tsxWhat changed
messages/SuccessMessage.tsxstyle={{ fontWeight: 'semi-bold' }}→className='fw-semibold'SuccessMessage.jsAdminAPIKeys.js./SuccessMessage→./messages/SuccessMessageFeatureImport.tsxcomponents/SuccessMessage→components/messages/SuccessMessage// Before
// After
Why this matters
'semi-bold'is not a valid CSSfont-weightvalue. Valid values arenormal,bold,lighter,bolder, or numeric (100–900). The browser silently ignores the invalid declaration, so the "SUCCESS" title has been rendering with defaultfont-weight: 400instead of the intended600.The consolidation removes 47 lines of duplicate code (a class component importing ionicons + the old Icon API) in favour of the existing typed functional component.
Test plan
npm run typecheck— no project source errorsnpx eslint --fix— passes clean on changed filesCloses #6872