chore: rebase React 19 migration on main (CI test)#6920
chore: rebase React 19 migration on main (CI test)#6920talissoncosta wants to merge 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
front-end
Docker builds report
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
🔄 Run: #15219 (attempt 1)
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Failed testsfirefox › tests/change-request-test.pw.ts › Change Request Tests › Change requests can be created, approved, and published with 4-eyes approval @enterprise |
React 19's createRoot().unmount() is asynchronous, unlike the old unmountComponentAtNode which was synchronous. The previous approach of unmounting then immediately recreating a root on the same element caused a race condition where the old modal's fade-out transition hadn't completed before the new content was rendered, leaving a ghost dialog overlay that blocked pointer events. Fix: lazily create the root once and reuse it — React reconciles new content on subsequent render() calls without needing to destroy the tree. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Failed testsfirefox › tests/flag-tests.pw.ts › Flag Tests › Feature flags can be created, toggled, edited, and deleted across environments @oss |
|
Closing in favor of initial #6764 |
2 participants
Summary
mainpackage.jsonconflict (@flagsmith/flagsmith+@dnd-kitdeps)package-lock.jsonThis PR is for CI validation only — not intended to merge. Testing whether the React 19 migration passes E2E after rebasing on latest main.
Test plan
🤖 Generated with Claude Code