Skip to content

fix(FileLogger): allow for continuous flushing#1247

Merged
BotellaA merged 2 commits intonextfrom
fix/file-logger-flush
Mar 13, 2026
Merged

fix(FileLogger): allow for continuous flushing#1247
BotellaA merged 2 commits intonextfrom
fix/file-logger-flush

Conversation

@BotellaA
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 7 concern(s)
  • include/geode/basic/file_logger_client.hpp:32:31: warning: [cppcoreguidelines-special-member-functions]

    class 'FileLoggerClient' defines a destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator

       32 |     class opengeode_basic_api FileLoggerClient : public LoggerClient
          |                               ^
  • include/geode/basic/file_logger_client.hpp:35:9: warning: [google-explicit-constructor]

    single-argument constructors must be marked explicit to avoid unintentional implicit conversions

       35 |         FileLoggerClient( std::string_view file_path );
          |         ^
          |         explicit 
  • include/geode/basic/file_logger_client.hpp:36:9: warning: [cppcoreguidelines-explicit-virtual-functions]

    annotate this function with 'override' or (rarely) 'final'

       36 |         ~FileLoggerClient();
          |         ^                  
          |                             override
  • include/geode/basic/logger_manager.hpp:36:31: warning: [cppcoreguidelines-special-member-functions]

    class 'LoggerManager' defines a destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator

       36 |     class opengeode_basic_api LoggerManager
          |                               ^
  • src/geode/basic/file_logger_client.cpp:27:10: error: [clang-diagnostic-error]

    'spdlog/spdlog.h' file not found

       27 | #include <spdlog/spdlog.h>
          |          ^~~~~~~~~~~~~~~~~
  • src/geode/basic/file_logger_client.cpp:40:9: warning: [cppcoreguidelines-pro-type-member-init]

    constructor does not initialize these fields: logger_impl_

       40 |         Impl( std::string_view file_path )
          |         ^
  • src/geode/basic/file_logger_client.cpp:40:9: warning: [google-explicit-constructor]

    single-argument constructors must be marked explicit to avoid unintentional implicit conversions

       40 |         Impl( std::string_view file_path )
          |         ^
          |         explicit 

Have any feedback or feature suggestions? Share it here.

@BotellaA BotellaA merged commit 097f79a into next Mar 13, 2026
20 checks passed
@BotellaA BotellaA deleted the fix/file-logger-flush branch March 13, 2026 18:13
@BotellaA
Copy link
Member Author

🎉 This PR is included in version 16.2.1-rc.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants