Skip to content

Relax faraday-multipart dependency to allow newer versions #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ionut998 wants to merge 2 commits into from
+5 −5
Closed

Relax faraday-multipart dependency to allow newer versions #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a913e00
Relax faraday-multipart dependency to allow newer versions
ionut998 Feb 6, 2026
d8096aa
Merge branch 'master' into Relax_faraday-multipart_dependency
nijeesh-stream Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
strategy:
max-parallel: 1
matrix:
ruby: ["3.0", "3.1", "3.4"]
ruby: ["3.0", "3.1", "3.4", "4.0"]
name: 💎 Ruby ${{ matrix.ruby }}
steps:
- uses: actions/checkout@v4
Expand All @@ -21,10 +21,10 @@ jobs:
bundler-cache: true

- run: bundle exec rake rubocop
if: ${{ matrix.ruby == '3.4' }}
if: ${{ matrix.ruby == '4.0' }}

- run: bundle exec srb tc
if: ${{ matrix.ruby == '3.4' }}
if: ${{ matrix.ruby == '4.0' }}

- run: bundle exec rspec ./spec --require spec_helper
env:
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ For the client-side integrations (web and mobile) have a look at the JavaScript,

## ⚙️ Installation

[`stream-chat-ruby`](https://rubygems.org/gems/stream-chat-ruby) supports Ruby version `3.0` and greater. We test against Ruby versions `3.0`, `3.1` and `3.4`.
[`stream-chat-ruby`](https://rubygems.org/gems/stream-chat-ruby) supports Ruby version `3.0` and greater. We test against Ruby versions `3.0`, `3.1`, `3.4` and 4.0.

```bash
$ gem install stream-chat-ruby
Expand Down
2 changes: 1 addition & 1 deletion stream-chat.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Gem::Specification.new do |gem|
}

gem.add_dependency 'faraday', '~> 2.12.2'
gem.add_dependency 'faraday-multipart', '~> 1.1.0'
gem.add_dependency 'faraday-multipart', '>=1.1.0'
Copy link

@cursor cursor bot Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unbounded dependency allows future breaking major versions

Medium Severity

The faraday-multipart constraint was changed from ~> 1.1.0 to >=1.1.0, removing any upper bound. The PR intent is to allow v1.2.0, but this also permits any future major version (2.0, 3.0, etc.) that could contain breaking changes. Every other dependency in this gemspec uses ~> to cap the major version. The appropriate constraint here would be ~> 1.1 (allows >= 1.1.0 and < 2.0.0).

Fix in Cursor Fix in Web

gem.add_dependency 'faraday-net_http_persistent', '~> 2.3.0'
gem.add_dependency 'jwt', '~> 2.10'
gem.add_dependency 'net-http-persistent', '~> 4.0'
Expand Down