Skip to content

fix(healthcare): set responseType to JSON instead of Buffer in deleteFhirResourcePurge.js#4248

Open
angelcaamal wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
angelcaamal:fix-fhir-delete-resource-purge
Open

fix(healthcare): set responseType to JSON instead of Buffer in deleteFhirResourcePurge.js#4248
angelcaamal wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
angelcaamal:fix-fhir-delete-resource-purge

Conversation

@angelcaamal
Copy link
Contributor

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@angelcaamal angelcaamal requested a review from a team as a code owner March 5, 2026 17:41
@angelcaamal angelcaamal added the api: healthcare Issues related to the Cloud Healthcare API API. label Mar 5, 2026
@angelcaamal angelcaamal requested review from a team as code owners March 5, 2026 17:41
@angelcaamal angelcaamal added the samples Issues that are directly related to samples. label Mar 5, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the reliability and clarity of the deleteFhirResourcePurge.js script. It corrects the response type to ensure proper data handling and adds error handling for more robust operation. The system test has been updated to reflect the changes in output messaging.

Highlights

  • Bug Fix: Addressed an issue where the response type was incorrectly set to 'Buffer' instead of 'JSON' in the deleteFhirResourcePurge.js file.
  • Error Handling: Implemented a try-catch block to handle potential errors during the FHIR resource purging process, providing more informative error messages.
  • Test Update: Updated the system test to align with the new output message format, ensuring the test accurately reflects the functionality.
Activity
  • The pull request addresses issue #.
  • The author has confirmed adherence to contribution guidelines, including passing tests and linting.
  • The author requests merging upon approval.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue in deleteFhirResourcePurge.js by introducing error handling and correctly configuring the API client to manage empty responses, preventing a JSON parsing error. The system test has been updated to align with the new output message. My feedback includes suggestions to enhance error logging for improved diagnostics and to simplify a test assertion for better code clarity and maintainability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: healthcare Issues related to the Cloud Healthcare API API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant