Add gif file export via graphene cli

[TrueDoctor]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the graphene-cli by introducing support for exporting documents as animated GIF files. This new capability allows users to render dynamic content from their .graphite documents into a widely supported animation format, complete with configurable animation parameters. The change integrates GIF encoding into the existing export pipeline, providing a more versatile output option for animated graph compositions.

Highlights

• GIF Export Functionality: Added the ability to export .graphite documents as animated GIF files via the graphene-cli.
• Animation Parameters: Introduced new command-line arguments (--fps, --frames, --duration) for controlling GIF animation properties like frame rate, total frames, and animation duration.
• Image Crate Update: Enabled the gif feature for the image crate in Cargo.toml to support GIF encoding.

Changelog

• Cargo.toml
  • Enabled the 'gif' feature for the 'image' crate.
• node-graph/graphene-cli/src/export.rs
  • Added TimingInformation and Duration imports.
  • Extended the FileType enum to include Gif.
  • Updated detect_file_type to recognize .gif file extensions.
  • Modified write_raster_image to correctly handle FileType::Gif as an unreachable case, indicating it's handled by a separate function.
  • Introduced a new AnimationParams struct to encapsulate GIF animation settings (frames per second, total frames).
  • Implemented the export_gif asynchronous function for rendering and encoding animated GIFs from multiple frames.
• node-graph/graphene-cli/src/main.rs
  • Updated the Export command description to include GIF as a supported output format.
  • Added new command-line arguments (--fps, --frames, --duration) to the Export command for configuring GIF animation.
  • Modified the main function to conditionally call the new export_gif function when the output file type is GIF, passing the animation parameters.
• node-graph/interpreted-executor/benches/benchmark_util.rs
  • Removed two println! debug statements related to network processing.

Activity

• No human activity (comments, reviews) has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a significant new feature: exporting animations as GIF files from the command line. The implementation is well-structured, introducing AnimationParams to handle animation settings and a dedicated export_gif function for the rendering loop. The changes to the CLI arguments are also correctly implemented. I have a few suggestions to improve robustness and clarity, particularly around input validation for animation parameters.

[cubic-dev-ai]

1 issue found across 4 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="node-graph/graphene-cli/src/main.rs">

<violation number="1" location="node-graph/graphene-cli/src/main.rs:80">
P2: The `fps` parameter accepts zero or negative values, which will cause a panic at runtime when rendering GIF frames. `Duration::from_secs_f64(NaN)` (from `0/0`) or `Duration::from_secs_f64(-x)` both panic. Consider adding a `value_parser` constraint or validating `fps > 0` before use.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}