Open
Conversation
ndgrigorian
force-pushed
the
update-umath-patching
branch
4 times, most recently
from
c05279b to
1a4529a
Compare
ndgrigorian
requested review from
antonwolfy,
jharlow-intel and
xaleryb
as code owners
Collaborator
Author
|
@antonwolfy @jharlow-intel |
ndgrigorian
force-pushed
the
update-umath-patching
branch
from
1a4529a to
e40ef5a
Compare
antonwolfy
reviewed
Mar 10, 2026
antonwolfy
reviewed
Mar 10, 2026
| @@ -193,11 +193,11 @@ def test_reduce_complex(func, dtype): | |||
|
|
|||
|
|
|||
| def test_patch(): | |||
Collaborator
There was a problem hiding this comment.
Can we add more testing to verify:
- reference counting behavior (nested contexts)
- new error handling paths
- multi-threaded scenarios that trigger warnings
- verbose parameter
Collaborator
Author
There was a problem hiding this comment.
I think we should wait on multi-threaded scenarios for free-threading support (more convenient/aligned with what we're interested in supporting), but the rest I will add
antonwolfy
reviewed
Mar 10, 2026
* Add safety checks to patching * Add warnings related to multi-threaded programs * Implement _GlobalPatch wrapper class which implements patching globally * Rename _patch module to _patch_numpy * Rename patching functions
ndgrigorian
force-pushed
the
update-umath-patching
branch
from
a6a0c96 to
711df0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
mkl_fftandmkl_randompatching interfaces