Open
Conversation
AxelGes
reviewed
Mar 4, 2026
AxelGes
reviewed
Mar 4, 2026
7 tasks
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
The V2 API returns a different providerOrderId format (e.g. PayPal's numeric ID or null) than the ramps order code used as the lookup key. When getOrder merged the API response onto an existing order, the spread overwrote providerOrderId, breaking all subsequent lookups via getOrderById and causing blank Order Details screens. Always set providerOrderId to orderCode after the merge so the canonical lookup key is never lost. Made-with: Cursor
Contributor
Author
|
@cursoragent fix the linting issue |
|
Fixed the linting issue! The problem was a negated condition at line 1949 in Changed:
The linting now passes successfully, and I've committed and pushed the fix to the |
Co-authored-by: George Weiler <georgejweiler@gmail.com>
georgeweiler
commented
Mar 10, 2026
| if (!buyWidget?.url) { | ||
| return null; | ||
| } | ||
| return buyWidget; |
Contributor
Author
There was a problem hiding this comment.
breaking: we are now returning both the URL and the extra data such as the supported browser type and custom order ID.
amitabh94
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Introduces controller API support for custom-action ramp flows (e.g., PayPal).
What changed:
getBuyWidgetData(quote)— ReplacesgetWidgetUrl. ReturnsBuyWidget | null(url, optionalbrowser, optionalorderId) instead ofstring | null. Returnsnullwhen fetch fails or no URL is available.addPrecreatedOrder(params)— New method accepting{ orderId, providerCode, walletAddress, chainId? }. Parses order IDs (including/orders/path format), normalizesproviderCode(strips/providers/prefix), and inserts a stubRampsOrderinPrecreatedstatus for existing polling to hydrate.What stays untouched: Existing controller state shape, polling behavior, and other order flows remain unchanged aside from the new API surface.
Dependencies: None in core; mobile and extension consume these changes.
References
Checklist
Note
Medium Risk
Medium risk due to a breaking public API change (
getWidgetUrl->getBuyWidgetData) and new order-state mutations (addPrecreatedOrder,getOrdernow inserts missing orders) that can affect ramp UI/polling behavior for consumers.Overview
BREAKING: Replaces
getWidgetUrlwithgetBuyWidgetData, returning aBuyWidget | null(includingbrowser/orderId) and now propagating service-call errors instead of swallowing them.Adds
addPrecreatedOrderto register a provider order ID (parsing/orders/IDs and normalizing provider codes) by inserting a stubRampsOrderinPrecreatedstatus so existing polling can hydrate it, and updatesgetOrderto push the order into state when it isn’t already present.Exports
normalizeProviderCode, updates tests to cover the new APIs/edge cases, and documents the breaking change in the changelog.Written by Cursor Bugbot for commit 64885db. This will update automatically on new commits. Configure here.