Skip to content

feat: add support for predict deposit and order#8135

Open
caieu wants to merge 3 commits intomainfrom
predict/deposit-and-order
Open

feat: add support for predict deposit and order#8135
caieu wants to merge 3 commits intomainfrom
predict/deposit-and-order

Conversation

@caieu
Copy link
Contributor

@caieu caieu commented Mar 6, 2026

Explanation

Summary

This PR adds support for a new predictDepositAndOrder transaction type in the transaction-controller. It updates the TransactionType enum, associated types, tests, and changelog to recognize and support this combined operation.

Why

To enable clients (e.g., Predict integrations) to handle transactions that combine deposit + order placement into a single transaction type, improving consistency and simplifying transaction handling across consumers.

Changes

  • ➕ Added TransactionType.predictDepositAndOrder to the TransactionType enum.
  • 🛠 Updated related TypeScript types to support the new transaction type.
  • 🧪 Added test coverage to validate the new enum value is defined and exported correctly.
  • 📝 Updated CHANGELOG.md.

Test Plan

  • Confirmed the new transaction type is properly exported.
  • Ensured existing tests pass with the new enum value included.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • [] I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Adds a single enum value plus changelog entry; behavior is unchanged unless downstream code starts using the new type.

Overview
Adds a new TransactionType.predictDepositAndOrder enum value to represent Predict transactions that combine a deposit and order placement.

Updates the transaction-controller changelog to document the new transaction type.

Written by Cursor Bugbot for commit 6fb113c. This will update automatically on new commits. Configure here.

@caieu caieu changed the title chore: add support for predict deposit and order feat: add support for predict deposit and order Mar 6, 2026
@caieu caieu marked this pull request as ready for review March 6, 2026 15:50
@caieu caieu requested review from a team as code owners March 6, 2026 15:50
matthewwalsh0
matthewwalsh0 previously approved these changes Mar 10, 2026
@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Mar 10, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 10, 2026
@caieu caieu force-pushed the predict/deposit-and-order branch from defdf38 to 6fb113c Compare March 10, 2026 13:39
@caieu caieu requested a review from matthewwalsh0 March 10, 2026 13:40
@caieu caieu enabled auto-merge March 10, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants