Draft
Conversation
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Previously we used the
isHexAddressfunction to validate the erc20token address. This function expects the input value to be in lowercase
hex.
Because we are splitting the address from the
terms, now we justvalidate that the entire terms is valid Hex (using case-insensitive
function) in the
makePermissionRulefunction.no-changelogbecause this is a fix to an unreleased change.References
Checklist
updated code as appropriate
for packages I've
changed
changes
in this PR and have prepared draft pull requests for clients and
consumer packages to resolve them
Note
Medium Risk
Changes account wallet ID generation and naming for
KeyringTypes.mpc, which can affect persisted wallet/group identifiers and UI grouping for MPC accounts. Scope is limited to type additions and grouping logic, with no direct cryptographic or auth changes.Overview
Adds a new
KeyringTypes.mpckeyring type and wires it into account/keyring naming helpers.Updates
KeyringRuleto treat MPC keyrings as multi-instance: it looks up the concrete keyring instancemetadata.idfor an account, incorporates it into the generated wallet ID (mpc/<id>), persists thatidin wallet metadata, and derives default wallet names likeMPC Wallet 1,MPC Wallet 2based on instance order.Written by Cursor Bugbot for commit ccd74c3. This will update automatically on new commits. Configure here.
Explanation
References
Checklist