[Java] Replace if with ? in Generated toIndentedString-methods#23209
Open
Chrimle wants to merge 22 commits intoOpenAPITools:masterfrom
Open
[Java] Replace if with ? in Generated toIndentedString-methods#23209Chrimle wants to merge 22 commits intoOpenAPITools:masterfrom
if with ? in Generated toIndentedString-methods#23209Chrimle wants to merge 22 commits intoOpenAPITools:masterfrom
Conversation
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Contributor
Author
|
Only ran |
Contributor
Author
|
On second thought, wouldn't it just be simpler with |
…String`-methods Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Contributor
Author
|
To be completely honest, I don't know if these methods should even be kept at all... that's a lot of boilerplate just to make the output prettier... |
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
toIndentedString-method to use String::valueOftoIndentedString-methods to Use Ternary Operators Instead of ifs
toIndentedString-methods to Use Ternary Operators Instead of ifsif with ? in Generated toIndentedString-methods
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors all generated Java classes'
toIndentedString-method to internally use Ternary Operator for null-checking, instead of a conventionalif-statement.NOTE: This change should make the method smaller, but will be equivalent in terms of functionality and performance.
Example:
Before:
After:
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Refactor
toIndentedStringacross all Java templates to use a single-line ternary null check and regenerate samples across Java generators. Behavior is unchanged ("null" for null;toString()with newline indentation otherwise).Written for commit 2909915. Summary will update on new commits.