Remove @shopify/react-i18n

[gonzaloriestra]

WHY are these changes introduced?

There's a warning about @shopify/react-i18n being deprecated:

❯ pnpm install
Scope: all 14 workspace projects
packages/ui-extensions-dev-console       |  WARN  deprecated @shopify/react-testing@5.4.0
packages/ui-extensions-dev-console       |  WARN  deprecated @shopify/react-i18n@7.14.0
 WARN  14 deprecated subdependencies found: @shopify/dates@2.1.1, @shopify/function-enhancers@3.1.0, @shopify/i18n@2.1.0, @shopify/name@1.3.0, @shopify/react-effect@5.2.0, @shopify/react-hooks@4.1.2, @shopify/useful-types@5.3.0, boolean@3.2.0, glob@10.5.0, glob@7.2.3, glob@8.1.0, inflight@1.0.6, node-domexception@1.0.0, whatwg-encoding@3.1.1
Packages: +12
++++++++++++
Progress: resolved 1991, reused 1841, downloaded 0, added 1, done
Done in 3.8s using pnpm v10.11.1

WHAT is this pull request doing?

Removes the depency:

❯ pnpm install
Scope: all 14 workspace projects
packages/ui-extensions-dev-console       |  WARN  deprecated @shopify/react-testing@5.4.0
 WARN  8 deprecated subdependencies found: @shopify/useful-types@5.3.0, boolean@3.2.0, glob@10.5.0, glob@7.2.3, glob@8.1.0, inflight@1.0.6, node-domexception@1.0.0, whatwg-encoding@3.1.1
Packages: +16 -1
++++++++++++++++-
Progress: resolved 1980, reused 1830, downloaded 0, added 1, done
Done in 4.4s using pnpm v10.11.1

How to test your changes?

pnpm install

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
• Existing analytics will cater for this addition
• PR includes analytics changes to measure impact

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes

[gonzaloriestra]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Remove @shopify/react-testing #6920
• Remove @shopify/react-i18n #6919 👈 (View in Graphite)
• Remove some deprecated dependencies #6918
• Fix peer dependencies issues #6898
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	76.93%	14542/18903
🟡	Branches	70.6%	7232/10244
🟡	Functions	75.95%	3699/4870
🟡	Lines	78.44%	13739/17515

Test suite run success

3788 tests passing in 1448 suites.

Report generated by 🧪jest coverage report action from fb4bc7a

[github-actions]

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

[binks-code-reviewer]

useI18n interpolation misses non-element React nodes and can corrupt rendered strings

interpolate() decides whether to do React-node interpolation by checking React.isValidElement(value). But React.ReactNode can be fragments, arrays, strings, numbers, etc. If replacements include fragments/arrays/other non-element nodes, hasReactNodes becomes false and values may be coerced via String(...), producing [object Object] or otherwise corrupted UI text.

[binks-code-reviewer]

🤖 Code Review · #projects-dev-ai for questions
React with 👍/👎 or reply — all feedback helps improve the agent.

✅ Complete - 1 findings

📋 History

✅ 1 findings