Skip to content

Ask for an alias on login when the email is not found#6935

Draft
gonzaloriestra wants to merge 1 commit intomainfrom
ask-for-alias-on-login
Draft

Ask for an alias on login when the email is not found#6935
gonzaloriestra wants to merge 1 commit intomainfrom
ask-for-alias-on-login

Conversation

@gonzaloriestra
Copy link
Contributor

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

04-50-022h2-44gy1

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@gonzaloriestra
Copy link
Contributor Author

/snapit

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260304105215

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.84% 14487/18376
🟡 Branches 73.17% 7207/9850
🟡 Functions 79.05% 3693/4672
🟡 Lines 79.18% 13686/17285

Test suite run success

3798 tests passing in 1449 suites.

Report generated by 🧪jest coverage report action from 00f8bfe

@gonzaloriestra gonzaloriestra force-pushed the ask-for-alias-on-login branch from c5fa758 to 72659f1 Compare March 4, 2026 11:16
@gonzaloriestra gonzaloriestra force-pushed the ask-for-alias-on-login branch 2 times, most recently from 072b6e7 to c81eb49 Compare March 5, 2026 11:31
@gonzaloriestra
Copy link
Contributor Author

/snapit

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260305113208

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@gonzaloriestra gonzaloriestra force-pushed the ask-for-alias-on-login branch from 1e7e3b8 to 00f8bfe Compare March 5, 2026 13:02
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/private/node/session/store.d.ts
@@ -21,6 +21,13 @@ export declare function remove(): Promise<void>;
  * @returns The alias for the session if it exists, otherwise undefined.
  */
 export declare function getSessionAlias(userId: string): Promise<string | undefined>;
+/**
+ * Sets the alias for a given user's session and persists it.
+ *
+ * @param userId - The user ID of the session to update.
+ * @param alias - The new alias to set.
+ */
+export declare function setSessionAlias(userId: string, alias: string): Promise<void>;
 /**
  * Finds a session by its alias.
  *

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant