Add TOML config regression tests#6940
Open
ryancbahan wants to merge 1 commit into02-27-add_cleanupfrom
Open
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
🤖 Code Review · #projects-dev-ai for questions ✅ Complete - No issues 📋 History✅ No issues → ✅ No issues |
Contributor
Coverage report
Test suite run success3791 tests passing in 1448 suites. Report generated by 🧪jest coverage report action from bec1a97 |
ryancbahan
force-pushed
the
02-27-add_cleanup
branch
from
aee3a10 to
ed08e49
Compare
ryancbahan
force-pushed
the
03-05-rcb_e2e-toml-testing
branch
from
f84e801 to
9cac1cf
Compare
ryancbahan
force-pushed
the
02-27-add_cleanup
branch
from
ed08e49 to
d53fb62
Compare
ryancbahan
force-pushed
the
03-05-rcb_e2e-toml-testing
branch
3 times, most recently
from
fdbbe21 to
eaa13bc
Compare
ryancbahan
force-pushed
the
02-27-add_cleanup
branch
from
1939c93 to
284ce31
Compare
ryancbahan
changed the title
ryancbahan
force-pushed
the
02-27-add_cleanup
branch
from
284ce31 to
d219d72
Compare
ryancbahan
force-pushed
the
03-05-rcb_e2e-toml-testing
branch
from
eaa13bc to
bec1a97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We want to catch regressions in
shopify.app.tomlparsing and validation. The CLI should accept all documented config options and reject invalid configurations with clear errors.WHAT is this pull request doing?
Static test data in
data/:data/valid-app/shopify.app.toml— comprehensive toml with all documented sections (access_scopes, webhooks, app_proxy, pos, build, auth, app_preferences, access.admin)data/valid-app/package.json— minimal package.jsondata/invalid-tomls/— 5 invalid toml files (bad syntax, wrong types, unknown section, missing webhook uri, invalid app_proxy prefix)New fixture:
setup/toml-app.ts— copiesdata/valid-app/to a temp dir, injectsclient_idfrom envTests:
toml-config.spec.ts:toml-config-invalid.spec.ts:.tomlfiles indata/invalid-tomls/app deploy --forcefails for each with non-zero exit codeHow to test your changes?
Measuring impact
n/a - test infrastructure