Skip to content

[3.92] Revert "Fix 401 Unauthorized on cart AJAX endpoints during shopify theme dev"#6992

Merged
karreiro merged 1 commit intostable/3.92from
backport-6975
Mar 12, 2026
Merged

[3.92] Revert "Fix 401 Unauthorized on cart AJAX endpoints during shopify theme dev"#6992
karreiro merged 1 commit intostable/3.92from
backport-6975

Conversation

@karreiro
Copy link
Contributor

Backport #6975

@karreiro karreiro requested a review from EvilGenius13 March 12, 2026 16:50
@karreiro karreiro requested review from a team as code owners March 12, 2026 16:50
@github-actions

This comment has been minimized.

@karreiro karreiro changed the title Revert "Fix 401 Unauthorized on cart AJAX endpoints during `shopify t… [3.92] Revert "Fix 401 Unauthorized on cart AJAX endpoints during shopify theme dev" Mar 12, 2026
@github-actions
Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

packages/cli-kit/dist/public/node/toml.d.ts
import { JsonMap } from '../../private/common/json.js';
export type JsonMapType = JsonMap;
/**
 * Given a TOML string, it returns a JSON object.
 *
 * @param input - TOML string.
 * @returns JSON object.
 */
export declare function decodeToml(input: string): JsonMapType;
/**
 * Given a JSON object, it returns a TOML string.
 *
 * @param content - JSON object.
 * @returns TOML string.
 */
export declare function encodeToml(content: JsonMap | object): string;

Existing type declarations

packages/cli-kit/dist/public/node/git.d.ts
@@ -1,13 +1,5 @@
 import { AbortError } from './error.js';
-export interface GitLogEntry {
-    hash: string;
-    date: string;
-    message: string;
-    refs: string;
-    body: string;
-    author_name: string;
-    author_email: string;
-}
+import { DefaultLogFields, ListLogLine } from 'simple-git';
 /**
  * Initialize a git repository at the given directory.
  *
@@ -48,12 +40,14 @@ export declare function addToGitIgnore(root: string, entry: string): void;
  *
  * @param repoUrl - The URL of the repository to clone.
  * @param destination - The directory where the repository will be cloned.
+ * @param progressUpdater - A function that will be called with the progress of the clone.
  * @param shallow - Whether to clone the repository shallowly.
  * @param latestTag - Whether to clone the latest tag instead of the default branch.
  */
 export interface GitCloneOptions {
     repoUrl: string;
     destination: string;
+    progressUpdater?: (statusString: string) => void;
     shallow?: boolean;
     latestTag?: boolean;
 }
@@ -70,7 +64,7 @@ export declare function downloadGitRepository(cloneOptions: GitCloneOptions): Pr
  * @param directory - The directory of the git repository.
  * @returns The latest commit of the repository.
  */
-export declare function getLatestGitCommit(directory?: string): Promise<GitLogEntry>;
+export declare function getLatestGitCommit(directory?: string): Promise<DefaultLogFields & ListLogLine>;
 /**
  * Add all files to the git index from the given directory.
  *

@github-actions
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.82% 14469/18357
🟡 Branches 73.09% 7189/9836
🟡 Functions 79.07% 3694/4672
🟡 Lines 79.16% 13670/17269

Test suite run success

3776 tests passing in 1448 suites.

Report generated by 🧪jest coverage report action from ed1bf34

@karreiro karreiro merged commit a2a7925 into stable/3.92 Mar 12, 2026
23 checks passed
@karreiro karreiro deleted the backport-6975 branch March 12, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants