Skip to content

feat: add skills inventory to feedback and support meta <name>#45

Merged
LadyBluenotes merged 6 commits intomainfrom
feat/feedback-skills-inventory
Mar 6, 2026
Merged

feat: add skills inventory to feedback and support meta <name>#45
LadyBluenotes merged 6 commits intomainfrom
feat/feedback-skills-inventory

Conversation

@KyleAMathews
Copy link
Collaborator

@KyleAMathews KyleAMathews commented Mar 6, 2026

Summary

Three improvements to feedback collection and the meta CLI command:

  1. Feedback now captures which skills the agent loaded vs. which were available but never read — helps maintainers distinguish "the skill was wrong" from "the agent never loaded the right skill"
  2. intent meta <name> prints the SKILL.md content directly instead of ignoring the argument
  3. Fixes feedback:skill: label prefix mismatch that caused label-not-found errors on feedback submission

Approach

Feedback skill: Added a new Phase 1a "Skills inventory" step that runs before gap/error analysis, plus a corresponding section in the markdown template. Renumbered existing subsections and updated cross-references.

CLI meta <name>: cmdMeta now accepts args. When a name is provided, it reads and prints the SKILL.md file. Includes path traversal guard (rejects .., /, \ in names) and try-catch on readFileSync. With no args, behavior is unchanged.

Label prefix fix: Changed feedback:<skill-name>skill:<skill-name> in three places: the feedback SKILL.md template, the setup checklist in cli.ts, and the meta-feedback submission in feedback.ts. This matches the labels that intent setup actually creates.

Key Invariants

  • Skills inventory is collected before gap/error analysis so it provides context for interpreting those signals
  • meta <name> exits with code 1 and a helpful message if the name doesn't match
  • meta with no args is unchanged
  • All label references use the skill: prefix consistently

Non-goals

  • No changes to FeedbackPayload type — feedback is submitted as markdown
  • No changes to meta-feedback flow beyond the label fix

Verification

pnpm vitest run
npx @tanstack/intent meta feedback-collection  # prints SKILL.md
npx @tanstack/intent meta nonexistent          # error with guidance
npx @tanstack/intent meta ../../etc/passwd     # rejected
npx @tanstack/intent meta                      # lists all (unchanged)

Files changed

  • meta/feedback-collection/SKILL.md — Added skills inventory phase (1a), template section, derivation table row; fixed label prefix; renumbered subsections
  • src/cli.tscmdMeta accepts optional name arg with path traversal guard; fixed label prefix in setup checklist; updated help text
  • src/feedback.ts — Fixed label prefix in meta-feedback submission

🤖 Generated with Claude Code

Feedback now captures which skills the agent loaded vs. which were
available but never read. This helps maintainers distinguish "the skill
was wrong" from "the agent never loaded the right skill."

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 6, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@tanstack/intent@45

commit: ab74f20

autofix-ci bot and others added 2 commits March 6, 2026 20:25
Feedback now captures which skills the agent loaded vs. which were
available but never read. This helps maintainers distinguish "the skill
was wrong" from "the agent never loaded the right skill."

Also adds support for `intent meta <name>` to print a specific
meta-skill's SKILL.md content directly.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@KyleAMathews KyleAMathews changed the title feat: add skills inventory to feedback collection feat: add skills inventory to feedback and support meta <name> Mar 6, 2026
autofix-ci bot and others added 3 commits March 6, 2026 20:38
The setup command creates skill:<name> labels but feedback collection
used feedback:<name>, causing label-not-found errors on submission.

Also adds path traversal guard and try-catch to meta <name> command.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@LadyBluenotes LadyBluenotes merged commit 860f031 into main Mar 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants