Disable rtcheck if sanitizers are enabled#166
Open
joeloftusdev wants to merge 1 commit intoTracktion:developfrom
Open
Disable rtcheck if sanitizers are enabled#166joeloftusdev wants to merge 1 commit intoTracktion:developfrom
joeloftusdev wants to merge 1 commit intoTracktion:developfrom
Conversation
Disable rtcheck when using address or thread sanitizers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates CMakeLists.txt to automatically set
PLUGINVAL_ENABLE_RTCHECK=OFFif eitherWITH_ADDRESS_SANITIZERorWITH_THREAD_SANITIZERis enabled.Fixes a crash when running with ThreadSanitizer. Both TSan and librtcheck were wrapping libc functions like stat(), which caused a conflict during startup and led to a segfault before main() ran.