Skip to content

FIX: Input Actions Editor toolbar buttons no longer overlap [ISXB-1783]#2374

Open
K-Tone wants to merge 4 commits intodevelopfrom
fix/ISXB-1783-input-actions-editor-button-overlap
Open

FIX: Input Actions Editor toolbar buttons no longer overlap [ISXB-1783]#2374
K-Tone wants to merge 4 commits intodevelopfrom
fix/ISXB-1783-input-actions-editor-button-overlap

Conversation

@K-Tone
Copy link
Collaborator

@K-Tone K-Tone commented Mar 12, 2026

Description

Link: https://jira.unity3d.com/browse/ISXB-1783

When the Input Actions Editor window is docked and narrow, the top buttons (Save Asset, Devices, Control Schemes) happen to overlap because of how they are laid out. To address that, we set the minimum width for the window area.

This fix was made with the assistance of Cursor.

Testing status & QA

Local testing, pending QA

Overall Product Risks

  • Complexity: Low
  • Halo Effect: Low

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

… when window is narrow

- Set min-width 520px on the editor root so Save Asset, Devices, Control Schemes stay visible when docked and resized.

Made-with: Cursor
Copy link
Contributor

@u-pr u-pr bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

I have reviewed the changes. The PR is in excellent shape, with only one minor suggestion for improving maintainability.

🤖 Helpful? 👍/👎

@codecov-github-com
Copy link

codecov-github-com bot commented Mar 12, 2026

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff             @@
##           develop    #2374      +/-   ##
===========================================
- Coverage    77.90%   77.90%   -0.01%     
===========================================
  Files          476      481       +5     
  Lines        97613    97691      +78     
===========================================
+ Hits         76048    76104      +56     
- Misses       21565    21587      +22     
Flag Coverage Δ
inputsystem_MacOS_2022.3 5.50% <ø> (-0.03%) ⬇️
inputsystem_MacOS_2022.3_project 75.41% <ø> (+0.01%) ⬆️
inputsystem_MacOS_6000.0 5.28% <ø> (-0.03%) ⬇️
inputsystem_MacOS_6000.0_project 77.31% <ø> (+0.01%) ⬆️
inputsystem_MacOS_6000.3 5.28% <ø> (-0.03%) ⬇️
inputsystem_MacOS_6000.3_project 77.31% <ø> (+0.01%) ⬆️
inputsystem_MacOS_6000.4 5.28% <ø> (-0.03%) ⬇️
inputsystem_MacOS_6000.4_project 77.32% <ø> (+0.01%) ⬆️
inputsystem_MacOS_6000.5 5.28% <ø> (-0.03%) ⬇️
inputsystem_MacOS_6000.5_project 77.31% <ø> (+0.01%) ⬆️
inputsystem_MacOS_6000.6 5.28% <ø> (-0.03%) ⬇️
inputsystem_MacOS_6000.6_project 77.32% <ø> (+0.01%) ⬆️
inputsystem_Ubuntu_2022.3_project 75.20% <ø> (+0.01%) ⬆️
inputsystem_Ubuntu_6000.0 5.28% <ø> (-0.03%) ⬇️
inputsystem_Ubuntu_6000.0_project 77.11% <ø> (+0.01%) ⬆️
inputsystem_Ubuntu_6000.3 5.28% <ø> (-0.03%) ⬇️
inputsystem_Ubuntu_6000.3_project 77.11% <ø> (+0.01%) ⬆️
inputsystem_Ubuntu_6000.4 5.29% <ø> (-0.03%) ⬇️
inputsystem_Ubuntu_6000.4_project 77.12% <ø> (+0.01%) ⬆️
inputsystem_Ubuntu_6000.5 5.29% <ø> (-0.03%) ⬇️
inputsystem_Ubuntu_6000.5_project 77.12% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.6 5.29% <ø> (-0.03%) ⬇️
inputsystem_Ubuntu_6000.6_project 77.12% <ø> (+0.01%) ⬆️
inputsystem_Windows_2022.3 5.50% <ø> (-0.03%) ⬇️
inputsystem_Windows_2022.3_project 75.53% <ø> (+<0.01%) ⬆️
inputsystem_Windows_6000.0 5.28% <ø> (-0.03%) ⬇️
inputsystem_Windows_6000.0_project 77.43% <ø> (+0.01%) ⬆️
inputsystem_Windows_6000.3 5.28% <ø> (-0.03%) ⬇️
inputsystem_Windows_6000.3_project 77.43% <ø> (+0.01%) ⬆️
inputsystem_Windows_6000.4 5.28% <ø> (-0.03%) ⬇️
inputsystem_Windows_6000.4_project 77.44% <ø> (+0.01%) ⬆️
inputsystem_Windows_6000.5 5.28% <ø> (-0.03%) ⬇️
inputsystem_Windows_6000.5_project 77.44% <ø> (+0.01%) ⬆️
inputsystem_Windows_6000.6 5.28% <ø> (-0.03%) ⬇️
inputsystem_Windows_6000.6_project 77.44% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@josepmariapujol-unity
Copy link
Collaborator

Could we add a screen shot for UI fixes :)

@K-Tone
Copy link
Collaborator Author

K-Tone commented Mar 12, 2026

Hey Josep, I'll get that addressed during today, alongside the uss comment

@josepmariapujol-unity
Copy link
Collaborator

Hey Josep, I'll get that addressed during today, alongside the uss comment

Super Anthony! Thank you :)

@josepmariapujol-unity
Copy link
Collaborator

Before:
BeforePR

After:
AfterPR

@K-Tone K-Tone changed the title Fix ISXB-1783: Input Actions Editor toolbar buttons no longer overlap… FIX: Input Actions Editor toolbar buttons no longer overla [ISXB-1783] Mar 12, 2026
@K-Tone K-Tone changed the title FIX: Input Actions Editor toolbar buttons no longer overla [ISXB-1783] FIX: Input Actions Editor toolbar buttons no longer overlap [ISXB-1783] Mar 12, 2026
@K-Tone K-Tone requested review from Pauliusd01 and ekcoh March 12, 2026 15:08
Copy link
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, scaled the window while docked and undocked with different windows scaling modes and did not notice any issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants