Skip to content

FIX: InputSystem warnings displayed with Unity editor 6000.6 version#2379

Closed
josepmariapujol-unity wants to merge 5 commits intodevelopfrom
input/warnings-6.6
Closed

FIX: InputSystem warnings displayed with Unity editor 6000.6 version#2379
josepmariapujol-unity wants to merge 5 commits intodevelopfrom
input/warnings-6.6

Conversation

@josepmariapujol-unity
Copy link
Collaborator

@josepmariapujol-unity josepmariapujol-unity commented Mar 12, 2026

Description

InputSystem warnings displayed with Unity editor 6000.6 version.

Warnings:
Screenshot 2026-03-12 at 12 24 38

Testing status & QA

Please describe the testing already done by you and what testing you request/recommend QA to execute. If you used or created any testing project please link them here too for QA.

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity: 1
  • Halo Effect: 1

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@josepmariapujol-unity josepmariapujol-unity self-assigned this Mar 12, 2026
@josepmariapujol-unity josepmariapujol-unity changed the title Input/warnings 6.6 FIX: InputSystem warnings displayed with Unity editor 6000.6 version Mar 12, 2026
Copy link
Contributor

@u-pr u-pr bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May require changes
This pull request introduces several critical serialization issues. Multiple fields marked with [NonSerialized] are essential for preserving input device state, layout matching, and editor window persistence. While some changes provide performance optimizations and valid cleanups, the serialization regressions require immediate attention.

🤖 Helpful? 👍/👎

@josepmariapujol-unity josepmariapujol-unity marked this pull request as draft March 12, 2026 14:06
@codecov-github-com
Copy link

codecov-github-com bot commented Mar 12, 2026

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff             @@
##           develop    #2379      +/-   ##
===========================================
- Coverage    77.90%   77.89%   -0.01%     
===========================================
  Files          476      481       +5     
  Lines        97613    97691      +78     
===========================================
+ Hits         76048    76100      +52     
- Misses       21565    21591      +26     
Flag Coverage Δ
inputsystem_MacOS_2022.3 5.50% <ø> (-0.03%) ⬇️
inputsystem_MacOS_2022.3_project 75.40% <100.00%> (+<0.01%) ⬆️
inputsystem_MacOS_6000.0 5.28% <ø> (-0.03%) ⬇️
inputsystem_MacOS_6000.0_project 77.30% <100.00%> (+0.01%) ⬆️
inputsystem_MacOS_6000.3 5.28% <ø> (-0.03%) ⬇️
inputsystem_MacOS_6000.3_project 77.30% <100.00%> (+0.01%) ⬆️
inputsystem_MacOS_6000.4 5.28% <ø> (-0.03%) ⬇️
inputsystem_MacOS_6000.4_project 77.31% <100.00%> (+0.01%) ⬆️
inputsystem_MacOS_6000.5 5.28% <ø> (-0.03%) ⬇️
inputsystem_MacOS_6000.5_project 77.31% <100.00%> (+<0.01%) ⬆️
inputsystem_MacOS_6000.6 5.28% <ø> (-0.03%) ⬇️
inputsystem_MacOS_6000.6_project 77.31% <100.00%> (+<0.01%) ⬆️
inputsystem_Ubuntu_2022.3_project 75.20% <100.00%> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.0_project 77.11% <100.00%> (+0.01%) ⬆️
inputsystem_Ubuntu_6000.3_project 77.11% <100.00%> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.4_project 77.12% <100.00%> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.5_project 77.12% <100.00%> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.6_project 77.12% <100.00%> (+0.01%) ⬆️
inputsystem_Windows_2022.3_project 75.53% <100.00%> (+<0.01%) ⬆️
inputsystem_Windows_6000.0_project 77.43% <100.00%> (+<0.01%) ⬆️
inputsystem_Windows_6000.3_project 77.43% <100.00%> (+<0.01%) ⬆️
inputsystem_Windows_6000.4_project 77.43% <100.00%> (+<0.01%) ⬆️
inputsystem_Windows_6000.5_project 77.44% <100.00%> (+0.01%) ⬆️
inputsystem_Windows_6000.6_project 77.43% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...utSystem.Editor/InputActionReferenceEditorTests.cs 97.61% <100.00%> (ø)
Assets/Tests/InputSystem/Plugins/UITests.cs 94.67% <100.00%> (ø)
...utsystem/InputSystem/Devices/InputDeviceMatcher.cs 62.54% <ø> (ø)
...system/InputSystem/Devices/Remote/InputRemoting.cs 81.32% <ø> (ø)
...em/InputSystem/Editor/Internal/InputStateWindow.cs 0.00% <ø> (ø)
...Editor/UITKAssetEditor/InputActionsEditorWindow.cs 52.85% <ø> (-1.81%) ⬇️
....inputsystem/InputSystem/Events/InputEventTrace.cs 84.61% <ø> (ø)
.../com.unity.inputsystem/InputSystem/InputManager.cs 91.74% <ø> (-0.03%) ⬇️

... and 6 files with indirect coverage changes

@josepmariapujol-unity josepmariapujol-unity marked this pull request as ready for review March 12, 2026 14:32
Copy link
Contributor

@u-pr u-pr bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect
No new unique findings were identified in this review pass. All critical issues regarding serialization risks, state persistence across domain reloads, and performance optimizations have already been documented in the existing comments.

🤖 Helpful? 👍/👎

Copy link
Collaborator

@jfreire-unity jfreire-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, we might need to look into this , pinging you locally.

@josepmariapujol-unity
Copy link
Collaborator Author

#2380

@josepmariapujol-unity josepmariapujol-unity deleted the input/warnings-6.6 branch March 12, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants