Fix wrong icons in Light theme

[thomas-tu]

Purpose of this PR

When using the Editor Light theme, some icons pulled are from the Dark theme. The affected icons are reference throught the [Icon(icon-path)] attribute so they follow the rule where file paths should be named as following:

my-icon.png --> light theme
d_my-icon.png --> dark theme

Probuilder handles the loading and the differentiation between both skins for most icon, by using its own IconUtility.GetIcon() but it follow differents rules:

my-icon.png --> dark theme
my-icon_Light.png --> light theme

I've updated the method so we can override for the specific case where the targeted icon is also being used with the IconAttribute. It's the case for one of the icon where it's in an attribute, but also being loaded through the API.

Before:

After:

Links

Jira: UUM-133531

Comments to Reviewers

[List known issues, planned work, provide any extra context for your code.]

[codecov-github-com]

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff           @@
##           master     #656   +/-   ##
=======================================
  Coverage   36.05%   36.06%           
=======================================
  Files         277      277           
  Lines       34909    34917    +8     
=======================================
+ Hits        12588    12593    +5     
- Misses      22321    22324    +3     

Flag	Coverage Δ
probuilder_MacOS_6000.0	34.52% <ø> (-0.06%)	⬇️
probuilder_MacOS_6000.3	34.52% <ø> (-0.06%)	⬇️
probuilder_MacOS_6000.4	34.52% <ø> (-0.06%)	⬇️
probuilder_MacOS_6000.5	34.52% <ø> (-0.06%)	⬇️
probuilder_MacOS_6000.6	34.52% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

[marnadeau]

The helpbox custom icon is not showing up on dark theme

Also, all editor helpbox have recently been updated to use a 16px. Could you change the icon size to make them match (and fix the blurry effect at the same time)
Thanks!

[unity-kristinn]

please fix problems with ci

also

getting this log message when updating package to this pr (also, shouldn't this be a warning? not a message?)

[thomas-tu]

please fix problems with ci

also

getting this log message when updating package to this pr (also, shouldn't this be a warning? not a message?)

Thanks. I'll check, but it's a message from the Editor I think.

[thomas-tu]

[9acc831](/Unity-Technologies/com.unity.probuilder/pull/656/commits/9acc8316fe9ecf47e2f723c98a1a8ae409a52b25)

@unity-kristinn, it should fixed with 9acc831.

Also, all editor helpbox have recently been updated to use a 16px. Could you change the icon size to make them match (and fix the blurry effect at the same time)

@marnadeau I updated the code so the new styling is applied on 6.5+. Helpbox still has 32px icon in all the previous versions of the Editor.

[marnadeau]

Everything is perfect now 🙏

[varinotmUnity]

lgtm