Block Visibility: change visibility class#11169
Block Visibility: change visibility class#11169t-hamano wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
LGTM - manually tested and against WordPress/gutenberg#76166
| * they should be sanitized and kebab-cased. | ||
| */ | ||
| $visibility_class = 'wp-block-hidden-' . $hidden_viewport_size; | ||
| $visibility_class = 'is-hidden-on-' . $hidden_viewport_size; |
There was a problem hiding this comment.
Does this class conflict with any existing one themes/plugin? Have you checked that?
I do quick search https://wpdirectory.net/search/01KK0QW5ZCT6GTEZDAMAZ33HXM for themes.
There was a problem hiding this comment.
That's a good question. I wouldn't be against reinstating wp as a namespace. After all it's wp that's generating it.
3 participants
Trac ticket: https://core.trac.wordpress.org/ticket/64802
Use of AI Tools
None