Skip to content

Improve display of SSVC in UI #2058 #2165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Mahaboobunnisa123 wants to merge 4 commits into
base: main
Choose a base branch
from
+23 −2
Draft

Improve display of SSVC in UI #2058 #2165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b8abaf
Use saneyaml.dump for SSVC display in UI
Mahaboobunnisa123 Feb 15, 2026
5661742
Merge branch 'main' into improve-ssvc-yaml-display
Mahaboobunnisa123 Feb 24, 2026
16880d5
Merge branch 'main' into improve-ssvc-yaml-display
Mahaboobunnisa123 Feb 27, 2026
18db02f
Merge branch 'main' into improve-ssvc-yaml-display
Mahaboobunnisa123 Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vulnerabilities/templates/advisory_detail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,7 @@
<summary class="is-size-7 has-text-link" style="cursor: pointer;">
View SSVC decision tree
</summary>
<pre>{{ ssvc.options|pprint }}</pre>
<pre>{{ ssvc.options_yaml }}</pre>
</details>
</div>
</div>
Expand Down
17 changes: 17 additions & 0 deletions vulnerabilities/tests/test_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
from vulnerabilities.utils import get_purl_version_class
from vulnerabilities.views import PackageDetails
from vulnerabilities.views import PackageSearch
from vulnerabilities.views import render_as_yaml

BASE_DIR = os.path.dirname(os.path.abspath(__file__))
TEST_DIR = os.path.join(BASE_DIR, "test_data/package_sort")
Expand Down Expand Up @@ -330,3 +331,19 @@ def test_aggregate_fixed_and_affected_packages(self):
end_time = time.time()
assert end_time - start_time < 0.05
self.assertEqual(response.status_code, 200)

class TestRenderAsYaml:
def test_render_as_yaml_with_ssvc_options(self):
options = [
{"Exploitation": "active"},
{"Automatable": "yes"},
{"Technical Impact": "total"},
]
result = render_as_yaml(options)
assert result == "- Exploitation: active\n- Automatable: yes\n- Technical Impact: total\n"

def test_render_as_yaml_with_none(self):
assert render_as_yaml(None) is None

def test_render_as_yaml_with_empty_list(self):
assert render_as_yaml([]) is None
6 changes: 5 additions & 1 deletion vulnerabilities/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# See https://aboutcode.org for more information about nexB OSS projects.
#
import logging

import saneyaml
from cvss.exceptions import CVSS2MalformedError
from cvss.exceptions import CVSS3MalformedError
from cvss.exceptions import CVSS4MalformedError
Expand Down Expand Up @@ -48,6 +48,9 @@

PAGE_SIZE = 20

def render_as_yaml(value):
Copy link
Member

@pombredanne pombredanne Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a value to have a function for a one liner?

Copy link
Author

@Mahaboobunnisa123 Mahaboobunnisa123 Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pombredanne, fair point! I added it as a named function for readability and reusability. it makes the template/view code cleaner when called multiple times instead of inlining yaml.dump(value) everywhere, and it's easier to extend later if we need to handle edge cases for example None values, custom YAML formatting. if you'd prefer I inline it directly, I'm happy to remove the function and keep it simple. Let me know your preference.

if value:
return saneyaml.dump(value, indent=2)

class PackageSearch(ListView):
model = models.Package
Expand Down Expand Up @@ -559,6 +562,7 @@ def add_ssvc(ssvc):
"vector": ssvc.vector,
"decision": ssvc.decision,
"options": ssvc.options,
"options_yaml": render_as_yaml(ssvc.options),
"advisory_url": ssvc.source_advisory.url,
"advisory": ssvc.source_advisory,
}
Expand Down