Skip to content

fix: Remove MacOS aria label workaround in listbox useOption#9736

Open
cbodin wants to merge 3 commits intoadobe:mainfrom
cbodin:fix/remove-listbox-option-voiceover-workaround
Open

fix: Remove MacOS aria label workaround in listbox useOption#9736
cbodin wants to merge 3 commits intoadobe:mainfrom
cbodin:fix/remove-listbox-option-voiceover-workaround

Conversation

@cbodin
Copy link

@cbodin cbodin commented Mar 4, 2026

Closes #9706

Removes the workaround to avoid SSR issues and allow for custom aria-* properties on list box items on MacOS Safari.

The issue the workaround was implemented for has been marked as resolved since 2023: https://bugs.webkit.org/show_bug.cgi?id=209279

Only verified to work on MacOS 26.3, Safari 26.3 so it probably needs more testing.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Verify that VoiceOver on MacOS Safari correctly reads aria-label and aria-labelledby on ListBoxItem's:
http://localhost:9003/?path=/story/react-aria-components-listbox--list-box-example&providerSwitcher-express=false&strict=true

🧢 Your Project:

@github-actions github-actions bot added the RAC label Mar 4, 2026
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on Safari 18.3 on MacOS 15.3.1, thanks for the fix!

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also tested it in Safari 26.3 and Chrome 145 on MacOS with VO, Safari 26.3 on iOS with VO, and Chrome 145 on Android with TalkBack 16
Additional testing showed same behaviour across all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ListBoxItem removes aria attributes in Safari, causing hydration issues

3 participants