feat(codemod): improvements to s1-to-s2 codemod (agent mode, E2E tests, more)#9754
Open
reidbarber wants to merge 11 commits intomainfrom
Open
feat(codemod): improvements to s1-to-s2 codemod (agent mode, E2E tests, more)#9754reidbarber wants to merge 11 commits intomainfrom
reidbarber wants to merge 11 commits intomainfrom
Conversation
…ching import and could miss v3 imports when an @react-spectrum/s2 import appears first
|
Build successful! 🎉 |
|
Build successful! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes three main improvements to the
npx @react-spectrum/codemods s1-to-s2upgrade assistant:--agentmode: this just transforms files, skipping the wizard steps.--componentshandling for sub-components: Previously, if you wanted to upgrade just TableView and rannpx @react-spectrum/codemods s1-to-s2 --components TableView, it would not updateCell,Column,Row, etc. Now, it includes all related components in the changes.Other minor fixes:
Itemnodes inTabListtoTabDialog,Popover, andFullscreenDialogremaps✅ Pull Request Checklist:
📝 Test Instructions:
Check out the tests.
🧢 Your Project: