Fix: ESLint 9+ path: handle child script errors in whitespace-async.js#3239
Open
dataCenter430 wants to merge 1 commit intoairbnb:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
CLIEngineis not available (ESLint 9+),whitespace.jsloads config by runningwhitespace-async.jswithexecSyncand parsing its stdout as JSON. The async script had no.catch()on its promise, so rejections became unhandled: the child could exit non-zero and print to stderr while the parent received empty or partial stdout and failed with a genericJSON.parseerror, hiding the real failure.Approach
whitespace.js; errors should still crash.Changes
packages/eslint-config-airbnb-base/whitespace-async.js: Add.catch()so that on rejection we log the error to stderr andprocess.exit(1).packages/eslint-config-airbnb/whitespace-async.js: Same change.On success, only JSON is written to stdout, so the parent’s
execSync+JSON.parsecontinues to work. On failure, the real error goes to stderr and the process exits 1, soexecSyncthrows and the thrown error includes the child’s stderr, making the root cause visible without masking crashes.Fixes #3238