Conversation
dturner
requested review from
AjeshRPai,
MagicalMeghan,
raystatic,
riggaroo,
simona-anomis and
srikrishnasakunia
as code owners
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a comprehensive update of project dependencies and build configurations across multiple sample applications. The primary goal is to upgrade the Compose BOM to its latest stable version, which in turn necessitated updates to a wide array of other AndroidX and third-party libraries. These changes ensure that the projects are running on the most current and compatible versions of their dependencies, improving stability and potentially enabling new features. Additionally, Gradle wrapper versions were standardized, and minor code style adjustments were made to improve consistency. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
dturner
force-pushed
the
compose-update-2026-03-10
branch
from
92e53ea to
8a30643
Compare
dturner
force-pushed
the
compose-update-2026-03-10
branch
from
8a30643 to
322adb3
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates various dependencies across the samples, most notably the Compose BOM and Gradle. While most of the dependency bumps and code formatting changes are correct, there's a critical issue in several gradle-wrapper.properties files. The distributionSha256Sum has not been updated to match the new Gradle version, which will cause the builds for those samples to fail. I've provided suggestions to fix these checksums.
| distributionPath=wrapper/dists | ||
| distributionSha256Sum=a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806 | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.1.0-bin.zip | ||
| distributionSha256Sum=7108fef32b066dcb8e074d4114e8614cfb6f1efeb9497c0b0268b7b4039f22bc |
There was a problem hiding this comment.
The Gradle wrapper's SHA-256 sum needs to be updated to match the new Gradle version (9.3.1). The current checksum is for Gradle 9.1.0, which will cause build failures.
distributionSha256Sum=22218d8a543194a32359b3323579685351668e1b93385b7410f13a48c5e02787
| distributionPath=wrapper/dists | ||
| distributionSha256Sum=a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806 | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.1.0-bin.zip | ||
| distributionSha256Sum=7108fef32b066dcb8e074d4114e8614cfb6f1efeb9497c0b0268b7b4039f22bc |
There was a problem hiding this comment.
The Gradle wrapper's SHA-256 sum needs to be updated to match the new Gradle version (9.3.1). The current checksum is for Gradle 9.1.0, which will cause build failures.
distributionSha256Sum=22218d8a543194a32359b3323579685351668e1b93385b7410f13a48c5e02787
| distributionPath=wrapper/dists | ||
| distributionSha256Sum=a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806 | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.1.0-bin.zip | ||
| distributionSha256Sum=7108fef32b066dcb8e074d4114e8614cfb6f1efeb9497c0b0268b7b4039f22bc |
There was a problem hiding this comment.
The Gradle wrapper's SHA-256 sum needs to be updated to match the new Gradle version (9.3.1). The current checksum is for Gradle 9.1.0, which will cause build failures.
distributionSha256Sum=22218d8a543194a32359b3323579685351668e1b93385b7410f13a48c5e02787
| distributionPath=wrapper/dists | ||
| distributionSha256Sum=a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806 | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.1.0-bin.zip | ||
| distributionSha256Sum=7108fef32b066dcb8e074d4114e8614cfb6f1efeb9497c0b0268b7b4039f22bc |
There was a problem hiding this comment.
The Gradle wrapper's SHA-256 sum needs to be updated to match the new Gradle version (9.3.1). The current checksum is for Gradle 9.1.0, which will cause build failures.
distributionSha256Sum=22218d8a543194a32359b3323579685351668e1b93385b7410f13a48c5e02787
| distributionPath=wrapper/dists | ||
| distributionSha256Sum=a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806 | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.1.0-bin.zip | ||
| distributionSha256Sum=7108fef32b066dcb8e074d4114e8614cfb6f1efeb9497c0b0268b7b4039f22bc |
There was a problem hiding this comment.
The Gradle wrapper's SHA-256 sum needs to be updated to match the new Gradle version (9.3.1). The current checksum is for Gradle 9.1.0, which will cause build failures.
distributionSha256Sum=22218d8a543194a32359b3323579685351668e1b93385b7410f13a48c5e02787
There was a problem hiding this comment.
Code Review
This pull request updates various dependencies across the samples, most notably the Compose BOM to 2026.02.01 and Gradle to 9.3.1. The dependency updates and related code changes, such as adopting new Gradle plugin syntax, are appropriate. However, there is a critical issue in several gradle-wrapper.properties files. While the distributionUrl was updated to use Gradle 9.3.1, the corresponding distributionSha256Sum was not updated. This mismatch will cause the Gradle wrapper validation to fail. I've added comments to all affected files pointing out this issue.
| distributionSha256Sum=a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806 | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.1.0-bin.zip | ||
| distributionSha256Sum=7108fef32b066dcb8e074d4114e8614cfb6f1efeb9497c0b0268b7b4039f22bc | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip |
There was a problem hiding this comment.
The distributionUrl has been updated to Gradle 9.3.1, but the distributionSha256Sum on line 17 has not been updated to match. This will cause the Gradle wrapper validation to fail.
Please update the SHA for gradle-9.3.1-bin.zip. The correct value is 2c0a252c5c4262a48191b63c40136a895c798864f704111327e5d7939955b544.
| distributionSha256Sum=a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806 | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.1.0-bin.zip | ||
| distributionSha256Sum=7108fef32b066dcb8e074d4114e8614cfb6f1efeb9497c0b0268b7b4039f22bc | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip |
There was a problem hiding this comment.
The distributionUrl has been updated to Gradle 9.3.1, but the distributionSha256Sum on line 17 has not been updated to match. This will cause the Gradle wrapper validation to fail.
Please update the SHA for gradle-9.3.1-bin.zip. The correct value is 2c0a252c5c4262a48191b63c40136a895c798864f704111327e5d7939955b544.
| distributionSha256Sum=a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806 | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.1.0-bin.zip | ||
| distributionSha256Sum=7108fef32b066dcb8e074d4114e8614cfb6f1efeb9497c0b0268b7b4039f22bc | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip |
There was a problem hiding this comment.
The distributionUrl has been updated to Gradle 9.3.1, but the distributionSha256Sum on line 17 has not been updated to match. This will cause the Gradle wrapper validation to fail.
Please update the SHA for gradle-9.3.1-bin.zip. The correct value is 2c0a252c5c4262a48191b63c40136a895c798864f704111327e5d7939955b544.
| distributionSha256Sum=a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806 | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.1.0-bin.zip | ||
| distributionSha256Sum=7108fef32b066dcb8e074d4114e8614cfb6f1efeb9497c0b0268b7b4039f22bc | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip |
There was a problem hiding this comment.
The distributionUrl has been updated to Gradle 9.3.1, but the distributionSha256Sum on line 17 has not been updated to match. This will cause the Gradle wrapper validation to fail.
Please update the SHA for gradle-9.3.1-bin.zip. The correct value is 2c0a252c5c4262a48191b63c40136a895c798864f704111327e5d7939955b544.
| distributionSha256Sum=a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806 | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.1.0-bin.zip | ||
| distributionSha256Sum=7108fef32b066dcb8e074d4114e8614cfb6f1efeb9497c0b0268b7b4039f22bc | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip |
There was a problem hiding this comment.
The distributionUrl has been updated to Gradle 9.3.1, but the distributionSha256Sum on line 17 has not been updated to match. This will cause the Gradle wrapper validation to fail.
Please update the SHA for gradle-9.3.1-bin.zip. The correct value is 2c0a252c5c4262a48191b63c40136a895c798864f704111327e5d7939955b544.
There was a problem hiding this comment.
Code Review
This pull request updates dependencies across various samples, including the Compose BOM and Gradle versions. However, a critical security vulnerability has been identified in the gradle-wrapper.properties files. Specifically, several projects updated the Gradle distribution URL but failed to update the corresponding SHA-256 integrity hash, which will cause builds to fail due to integrity check mismatches. Additionally, one project is missing the integrity hash entirely, posing a significant security risk by making the build process vulnerable to Man-in-the-Middle attacks. These issues must be addressed by providing the correct SHA-256 hashes for the new Gradle version to ensure both build stability and security.
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.2-bin.zip | ||
| distributionSha256Sum=7108fef32b066dcb8e074d4114e8614cfb6f1efeb9497c0b0268b7b4039f22bc |
There was a problem hiding this comment.
The Gradle wrapper is configured to download Gradle 9.3.1 without a distributionSha256Sum. This omission is a critical security vulnerability, as it makes the build process vulnerable to Man-in-the-Middle (MITM) attacks or compromised distribution servers, potentially leading to the execution of malicious code. It is highly recommended to add the distributionSha256Sum property with the correct SHA-256 hash for gradle-9.3.1-bin.zip to ensure the integrity of the downloaded Gradle distribution and enhance security.
distributionSha256Sum=e3f461a293d39f9621500318451b34a4140ac5f7435641da928b642a14a2432c
distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip
| distributionSha256Sum=a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806 | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.1.0-bin.zip | ||
| distributionSha256Sum=7108fef32b066dcb8e074d4114e8614cfb6f1efeb9497c0b0268b7b4039f22bc | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip |
There was a problem hiding this comment.
The distributionUrl has been updated to gradle-9.3.1-bin.zip, but the distributionSha256Sum remains set to the hash for Gradle 9.1.0 (a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806). This mismatch is a security concern as it indicates a failure in the integrity check, which will cause the Gradle wrapper to abort the download and break the build. Please update the distributionSha256Sum to the correct SHA-256 hash (e3f461a293d39f9621500318451b34a4140ac5f7435641da928b642a14a2432c) for gradle-9.3.1-bin.zip to ensure a secure and successful build process.
| distributionSha256Sum=a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806 | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.1.0-bin.zip | ||
| distributionSha256Sum=7108fef32b066dcb8e074d4114e8614cfb6f1efeb9497c0b0268b7b4039f22bc | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip |
There was a problem hiding this comment.
The distributionUrl has been updated to gradle-9.3.1-bin.zip, but the distributionSha256Sum remains set to the hash for Gradle 9.1.0 (a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806). This mismatch is a security concern as it indicates a failure in the integrity check, which will cause the Gradle wrapper to abort the download and break the build. Please update the distributionSha256Sum to the correct SHA-256 hash (e3f461a293d39f9621500318451b34a4140ac5f7435641da928b642a14a2432c) for gradle-9.3.1-bin.zip to ensure a secure and successful build process.
| distributionSha256Sum=a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806 | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.1.0-bin.zip | ||
| distributionSha256Sum=7108fef32b066dcb8e074d4114e8614cfb6f1efeb9497c0b0268b7b4039f22bc | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip |
There was a problem hiding this comment.
The distributionUrl has been updated to gradle-9.3.1-bin.zip, but the distributionSha256Sum remains set to the hash for Gradle 9.1.0 (a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806). This mismatch is a security concern as it indicates a failure in the integrity check, which will cause the Gradle wrapper to abort the download and break the build. Please update the distributionSha256Sum to the correct SHA-256 hash (e3f461a293d39f9621500318451b34a4140ac5f7435641da928b642a14a2432c) for gradle-9.3.1-bin.zip to ensure a secure and successful build process.
| distributionSha256Sum=a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806 | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.1.0-bin.zip | ||
| distributionSha256Sum=7108fef32b066dcb8e074d4114e8614cfb6f1efeb9497c0b0268b7b4039f22bc | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip |
There was a problem hiding this comment.
The distributionUrl has been updated to gradle-9.3.1-bin.zip, but the distributionSha256Sum remains set to the hash for Gradle 9.1.0 (a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806). This mismatch is a security concern as it indicates a failure in the integrity check, which will cause the Gradle wrapper to abort the download and break the build. Please update the distributionSha256Sum to the correct SHA-256 hash (e3f461a293d39f9621500318451b34a4140ac5f7435641da928b642a14a2432c) for gradle-9.3.1-bin.zip to ensure a secure and successful build process.
| distributionSha256Sum=a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806 | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.1.0-bin.zip | ||
| distributionSha256Sum=7108fef32b066dcb8e074d4114e8614cfb6f1efeb9497c0b0268b7b4039f22bc | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip |
There was a problem hiding this comment.
The distributionUrl has been updated to gradle-9.3.1-bin.zip, but the distributionSha256Sum remains set to the hash for Gradle 9.1.0 (a17ddd85a26b6a7f5ddb71ff8b05fc5104c0202c6e64782429790c933686c806). This mismatch is a security concern as it indicates a failure in the integrity check, which will cause the Gradle wrapper to abort the download and break the build. Please update the distributionSha256Sum to the correct SHA-256 hash (e3f461a293d39f9621500318451b34a4140ac5f7435641da928b642a14a2432c) for gradle-9.3.1-bin.zip to ensure a secure and successful build process.
1 participant
Updates the Compose BOM to version 2026.02.01 across all samples.