Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ use_repo(
pnpm = use_extension("@aspect_rules_js//npm:extensions.bzl", "pnpm")
pnpm.pnpm(
name = "pnpm",
pnpm_version = "10.30.3",
pnpm_version_integrity = "sha512-yWHR4KLY41TsqlFmuCJRZmi39Ey1vZUSLVkN2Bki9gb1RzttI+xKW+Bef80Y6EiNR9l4u+mBhy8RRdBumnQAFw==",
pnpm_version = "10.31.0",
pnpm_version_integrity = "sha512-45JziL+qgHjOt5t0j/wegnToTXUWPme8IuBsDTrtQ90VMVHL8R1/gwH/SsuYxovcXK32mJUygB/6/js+SmPCaA==",
)
use_repo(pnpm, "pnpm")

Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@
"type": "git",
"url": "git+https://github.com/angular/angular-cli.git"
},
"packageManager": "pnpm@10.30.3",
"packageManager": "pnpm@10.31.0",
"engines": {
"node": "^22.22.0 || >=24.13.1",
"npm": "Please use pnpm instead of NPM to install dependencies",
"yarn": "Please use pnpm instead of Yarn to install dependencies",
"pnpm": "10.30.3"
"pnpm": "10.31.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While pinning the pnpm version in the packageManager field is great for ensuring consistent environments, using a strict version in the engines field can be overly restrictive for developers who might not be using corepack. A developer with a slightly different patch version of pnpm installed globally would be blocked.

Using a caret range ^ would provide more flexibility without compromising the enforced version for corepack users. This aligns with the practice used for the node engine version in this same file.

Suggested change
"pnpm": "10.31.0"
"pnpm": "^10.31.0"

},
"author": "Angular Authors",
"license": "MIT",
Expand Down