fix(@angular/build): pass process environment variables to prerender workers#32732
Open
alan-agius4 wants to merge 1 commit intoangular:20.3.xfrom
Open
fix(@angular/build): pass process environment variables to prerender workers#32732alan-agius4 wants to merge 1 commit intoangular:20.3.xfrom
alan-agius4 wants to merge 1 commit intoangular:20.3.xfrom
Conversation
alan-agius4
added
the
target: lts
alan-agius4
added
the
action: review
alan-agius4
force-pushed
the
prerender-env-20
branch
from
0522c48 to
7d519d8
Compare
1 task
alan-agius4
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to pass process environment variables to prerender and route extraction workers. The implementation correctly uses the spread syntax to include process.env. However, there's a potential issue with how NG_ALLOWED_HOSTS is handled. If a user has this variable set in their environment, it will overwrite the default 'localhost' value, which can break the prerendering process as it needs to access localhost. I've suggested a fix to merge the user-provided hosts with localhost to prevent this issue, ensuring both user configuration and prerendering functionality are preserved.
…workers Worker processes used for prerendering and route extraction now inherit `process.env`. This ensures that any custom environment variables required by the application are available during the server-side rendering process. Closes angular#32730
alan-agius4
force-pushed
the
prerender-env-20
branch
from
7d519d8 to
067748a
Compare
dgp1130
approved these changes
Mar 10, 2026
alan-agius4
added
action: merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Worker processes used for prerendering and route extraction now inherit
process.env. This ensures that any custom environment variables required by the application are available during the server-side rendering process.Closes #32730