fix(core): make JSON-to-SQLite migration truly one-time#16884
Open
vereis wants to merge 1 commit intoanomalyco:devfrom
Open
fix(core): make JSON-to-SQLite migration truly one-time#16884vereis wants to merge 1 commit intoanomalyco:devfrom
vereis wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
68a7e24 to
f47641d
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16885
Type of change
What does this PR do?
The startup JSON->SQLite migration gate currently checks for
~/.local/share/opencode/opencode.db. On non-latestchannels, the active DB can be channel-specific (for exampleopencode-local.db), so that filename check can stay false forever and migration reruns every launch.This change switches the gate to a dedicated marker file at
~/.local/share/opencode/storage/json-sqlite-migration.doneand writes that marker after a successful migration run. That makes the migration truly one-time regardless of DB filename/channel.Why this approach instead of checking channel DB names: checking channel DB filenames only fixes the rerun case, but not the skip case where a DB file exists from prior schema migrations even though JSON->SQLite import never completed. A dedicated migration-completion marker tracks the actual event we care about.
How did you verify your code works?
nix shell nixpkgs#bun --command bun installnix shell nixpkgs#bun --command bun run --cwd packages/opencode typecheckScreenshots / recordings
Before:

After:

N/A (CLI startup behavior change, no UI change)
Checklist