fix(tui): avoid stuck QUEUED badges from orphan assistant messages#16907
Open
MaheshBhushan wants to merge 3 commits intoanomalyco:devfrom
Open
fix(tui): avoid stuck QUEUED badges from orphan assistant messages#16907MaheshBhushan wants to merge 3 commits intoanomalyco:devfrom
MaheshBhushan wants to merge 3 commits intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16856
Type of change
What does this PR do?
This fixes the stuck QUEUED badge when an old orphan assistant message exists in session history.
Before: pending used indLast over all messages for assistant entries missing ime.completed. If an older crashed/orphaned assistant message was still incomplete, pending pointed to it forever, so later user messages looked queued even when idle.
After: pending only considers the tail message, and only if it is an assistant message that is still incomplete and has no error.
Why this works: only the tail assistant message can represent current in-flight generation; historical orphan records should not drive live queued state.
How did you verify your code works?
Screenshots / recordings
Not included (small logic-only TUI state fix).
Checklist