HBASE-29940 GC Collector stats can't be displayed properly in JDK21#7822
Merged
Apache9 merged 1 commit intoapache:masterfrom Mar 6, 2026
Merged
HBASE-29940 GC Collector stats can't be displayed properly in JDK21#7822Apache9 merged 1 commit intoapache:masterfrom
Apache9 merged 1 commit intoapache:masterfrom
Conversation
Contributor
liuxiaocs7
commented
Feb 28, 2026
liuxiaocs7
commented
- see: HBASE-29940
liuxiaocs7
force-pushed
the
HBASE-29940
branch
from
b6537e2 to
dbf97b7
Compare
liuxiaocs7
changed the title
Contributor
Author
Apache9
reviewed
Mar 5, 2026
Contributor
Apache9
left a comment
Apache9
left a comment
There was a problem hiding this comment.
Could you please explain a bit on what is the real fix here?
Thanks.
Contributor
Author
Thanks for the comments, In short, the default implementation uses two GC Collectors, but in higher JDK versions, the situation changes, it could be two, three, or four. Therefore, we need a more universal approach to accommodate this scenario. For more details and images, attached in HBASE-29940 |
liuxiaocs7
commented
Mar 5, 2026
Comment on lines
+110
to
+111
| <% idx = 0; long totalGcTime = 0; for (GarbageCollectorMXBean gc : gcBeans) { totalGcTime += gc.getCollectionTime(); %> | ||
| <div class="tab-pane <%= idx == 0 ? "active" : "" %>" id="tab_gc_<%= idx %>" role="tabpanel"> |
Apache9
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.