Skip to content

HBASE-29963 Bump minimatch and serve in /hbase-website#7851

Merged
PDavid merged 1 commit intomasterfrom
dependabot/npm_and_yarn/hbase-website/multi-ae1f75c434
Mar 6, 2026
Merged

HBASE-29963 Bump minimatch and serve in /hbase-website#7851
PDavid merged 1 commit intomasterfrom
dependabot/npm_and_yarn/hbase-website/multi-ae1f75c434

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 5, 2026

Bumps minimatch to 3.1.5 and updates ancestor dependency serve. These dependencies need to be updated together.

Updates minimatch from 3.1.2 to 3.1.5

Commits

Updates serve from 14.2.5 to 14.2.6

Release notes

Sourced from serve's releases.

v14.2.6

Patch Changes

  • 7fcb924: Bump ajv to 8.18.0
  • b3888f9: Update serve-handler to 6.1.7 to fix ReDoS vulnerabilities
Changelog

Sourced from serve's changelog.

14.2.6

Patch Changes

  • 7fcb924: Bump ajv to 8.18.0
  • b3888f9: Update serve-handler to 6.1.7 to fix ReDoS vulnerabilities
Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Mar 5, 2026
@PDavid PDavid changed the title Bump minimatch and serve in /hbase-website HBASE-29963 Bump minimatch and serve in /hbase-website Mar 5, 2026
Bumps [minimatch](https://github.com/isaacs/minimatch) to 3.1.5 and updates ancestor dependency [serve](https://github.com/vercel/serve). These dependencies need to be updated together.

Updates `minimatch` from 3.1.2 to 3.1.5
- [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md)
- [Commits](isaacs/minimatch@v3.1.2...v3.1.5)

Updates `serve` from 14.2.5 to 14.2.6
- [Release notes](https://github.com/vercel/serve/releases)
- [Changelog](https://github.com/vercel/serve/blob/main/CHANGELOG.md)
- [Commits](vercel/serve@v14.2.5...v14.2.6)

---
updated-dependencies:
- dependency-name: minimatch
  dependency-version: 3.1.5
  dependency-type: indirect
- dependency-name: serve
  dependency-version: 14.2.6
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@PDavid PDavid force-pushed the dependabot/npm_and_yarn/hbase-website/multi-ae1f75c434 branch from 88b237c to 7c2e002 Compare March 5, 2026 11:35
Copy link
Contributor

@PDavid PDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I checked out the branch locally and built the website. It looks good.

@PDavid
Copy link
Contributor

PDavid commented Mar 5, 2026

Spotless complains about:

  • hbase-website/playwright-report/data/71ec87d76eb49e0c30e52f3edafb4411bde64b73.md
  • hbase-website/test-results/docs-Documentation-Page----c6b0b-o-single-page-documentation-webkit/error-context.md

Maybe we have to ignore hbase-website/playwright-report/* and hbase-website/test-results/* in spotless checks?

There was a failed e2e test:

[INFO] [83/105] [webkit] › e2e-tests/docs.spec.ts:192:3 › Documentation Page - Content & Navigation › can navigate to single-page documentation
[INFO]   1) [webkit] › e2e-tests/docs.spec.ts:192:3 › Documentation Page - Content & Navigation › can navigate to single-page documentation 
[INFO] 
[INFO]     Test timeout of 30000ms exceeded.
[INFO] 
[INFO]     Error: page.waitForLoadState: Test timeout of 30000ms exceeded.
[INFO] 
[INFO]       192 |   test("can navigate to single-page documentation", async ({ page }) => {
[INFO]       193 |     await page.goto("/docs/single-page");
[INFO]     > 194 |     await page.waitForLoadState("networkidle");
[INFO]           |                ^
[INFO]       195 |
[INFO]       196 |     // Verify URL
[INFO]       197 |     await expect(page).toHaveURL(/.*single-page/);
[INFO]         at /home/runner/work/hbase/hbase/src/hbase-website/e2e-tests/docs.spec.ts:194:16
[INFO] 
[INFO]     Error Context: test-results/docs-Documentation-Page----c6b0b-o-single-page-documentation-webkit/error-context.md
[INFO] 

As I saw these might be flaky, probably successful on next run.

@PDavid
Copy link
Contributor

PDavid commented Mar 5, 2026

Re-running Yetus General check was successful.

@PDavid PDavid self-assigned this Mar 5, 2026
@yuriipalam
Copy link
Contributor

Thanks David.

Maybe we have to ignore hbase-website/playwright-report/* and hbase-website/test-results/* in spotless checks?

What do you mean by ignoring? These are just logs.

I tested it locally, everything works. That's weird it's failing remotely. I am going to investigate. Perhaps the timeout is too small 🤷‍♂️

@yuriipalam
Copy link
Contributor

When I'm opening the details of the failing checks, I don't see any failures. That's weird. Am I doing something wrong @PDavid ?

@PDavid
Copy link
Contributor

PDavid commented Mar 5, 2026

When I'm opening the details of the failing checks, I don't see any failures. That's weird. Am I doing something wrong @PDavid ?

Thanks @yuriipalam for looking into these. 👍

Actually the first run of Yetus General check failed and produced these spotless errors:

  • hbase-website/playwright-report/data/71ec87d76eb49e0c30e52f3edafb4411bde64b73.md
  • hbase-website/test-results/docs-Documentation-Page----c6b0b-o-single-page-documentation-webkit/error-context.md

Then run the site build locally and then the spotless check and could not reproduce these issues locally.

So I re-run the Yetus General check and that is now successful:
https://github.com/apache/hbase/actions/runs/22716047463/

@yuriipalam
Copy link
Contributor

Cool, thanks @PDavid

@PDavid PDavid merged commit ba26e81 into master Mar 6, 2026
8 of 11 checks passed
@PDavid PDavid deleted the dependabot/npm_and_yarn/hbase-website/multi-ae1f75c434 branch March 6, 2026 07:36
@PDavid PDavid restored the dependabot/npm_and_yarn/hbase-website/multi-ae1f75c434 branch March 6, 2026 07:37
PDavid added a commit that referenced this pull request Mar 6, 2026
@PDavid PDavid deleted the dependabot/npm_and_yarn/hbase-website/multi-ae1f75c434 branch March 6, 2026 07:43
@PDavid
Copy link
Contributor

PDavid commented Mar 6, 2026

I screwed up the commit message, forgot to add the Jira ticket ID and merged it to master. I reverted it now.
Will do this again in #7868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants