HBASE-29963 Bump minimatch and serve in /hbase-website#7851
Conversation
Bumps [minimatch](https://github.com/isaacs/minimatch) to 3.1.5 and updates ancestor dependency [serve](https://github.com/vercel/serve). These dependencies need to be updated together. Updates `minimatch` from 3.1.2 to 3.1.5 - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v3.1.2...v3.1.5) Updates `serve` from 14.2.5 to 14.2.6 - [Release notes](https://github.com/vercel/serve/releases) - [Changelog](https://github.com/vercel/serve/blob/main/CHANGELOG.md) - [Commits](vercel/serve@v14.2.5...v14.2.6) --- updated-dependencies: - dependency-name: minimatch dependency-version: 3.1.5 dependency-type: indirect - dependency-name: serve dependency-version: 14.2.6 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
88b237c to
7c2e002
Compare
PDavid
left a comment
There was a problem hiding this comment.
LGTM.
I checked out the branch locally and built the website. It looks good.
|
Spotless complains about:
Maybe we have to ignore hbase-website/playwright-report/* and hbase-website/test-results/* in spotless checks? There was a failed e2e test: As I saw these might be flaky, probably successful on next run. |
|
Re-running Yetus General check was successful. |
|
Thanks David.
What do you mean by ignoring? These are just logs. I tested it locally, everything works. That's weird it's failing remotely. I am going to investigate. Perhaps the timeout is too small 🤷♂️ |
|
When I'm opening the details of the failing checks, I don't see any failures. That's weird. Am I doing something wrong @PDavid ? |
Thanks @yuriipalam for looking into these. 👍 Actually the first run of Yetus General check failed and produced these spotless errors:
Then run the site build locally and then the spotless check and could not reproduce these issues locally. So I re-run the Yetus General check and that is now successful: |
|
Cool, thanks @PDavid |
|
I screwed up the commit message, forgot to add the Jira ticket ID and merged it to master. I reverted it now. |
Bumps minimatch to 3.1.5 and updates ancestor dependency serve. These dependencies need to be updated together.
Updates
minimatchfrom 3.1.2 to 3.1.5Commits
7bba9783.1.5bd25942docs: add warning about ReDoS1a9c27cfix partial matching of globstar patterns1a2e0843.1.4ae24656update lockfileb100374limit recursion for **, improve perf considerably26ffeaalockfile update9eca892lock node version to 1400c323b3.1.330486b2update CI matrix and actionsUpdates
servefrom 14.2.5 to 14.2.6Release notes
Sourced from serve's releases.
Changelog
Sourced from serve's changelog.
Commits
f3c702cVersion Packages (#846)7fcb924Add changeset for #842a2fecb3chore(deps): update ajv to v8.18.0 (#842)b3888f9Bumpserve-handlerto6.1.7(#845)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.