refactor!: Enforce keyword-only arguments across all APIs#644
Draft
refactor!: Enforce keyword-only arguments across all APIs#644
Conversation
…nal APIs Add `*` separator to all function and method signatures (117 functions across 16 files) to enforce keyword-only argument passing. Update all internal callers (707 call sites in src/ and tests/), documentation examples (31 docs files), and website examples to use keyword syntax. BREAKING CHANGE: All function parameters (beyond self/cls) are now keyword-only. Callers must use `func(param=value)` instead of `func(value)`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vdusek
added
adhoc
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #644 +/- ##
===========================================
- Coverage 96.62% 75.60% -21.03%
===========================================
Files 45 45
Lines 4271 4271
===========================================
- Hits 4127 3229 -898
- Misses 144 1042 +898
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danpoletaev
force-pushed
the
refactor/enforce-keyword-only-args
branch
from
d4601d7 to
2fdc892
Compare
B4nan
force-pushed
the
refactor/enforce-keyword-only-args
branch
from
2fdc892 to
d4601d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*separator to all function and method signatures (117 functions across 16 files insrc/) to enforce keyword-only argument passingsrc/andtests/), documentation examples (31 docs files), and website examples to use keyword syntaxRedirectLogFormatter.formatand_ContextInjectingFilter.filter(logging framework overrides called positionally by Python internals)BREAKING CHANGE
All function parameters (beyond
self/cls) are now keyword-only. Callers must usefunc(param=value)instead offunc(value).Test plan
ruff checkpasses (zero lint errors)ruff formatpasses (all files formatted)ty checkpasses onsrc/anddocs/(zero new type errors)🤖 Generated with Claude Code