fix: upgrade prettier to ^3.0.0 for ESLint plugin compatibility (Issue #919)#926
Closed
zhengshui wants to merge 1 commit intocallstack:mainfrom
Closed
fix: upgrade prettier to ^3.0.0 for ESLint plugin compatibility (Issue #919)#926zhengshui wants to merge 1 commit intocallstack:mainfrom
zhengshui wants to merge 1 commit intocallstack:mainfrom
Conversation
Issue callstack#919: Doesn't work with NPM The template was using prettier@^2.8.8 but eslint-plugin-prettier@^5.5.4 requires prettier >= 3.0.0, causing npm install to fail with peer dependency conflicts. This change upgrades prettier to ^3.0.0 to ensure compatibility with the latest eslint-plugin-prettier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Issue #919: "Doesn't work with NPM"
Problem
When using
create-react-native-libraryto create a new library,npm installfails with the following error:This is because the template was using
prettier@^2.8.8buteslint-plugin-prettier@^5.5.4requiresprettier >= 3.0.0.Solution
Upgrade prettier from
^2.8.8to^3.0.0in the ESLint tool configuration to ensure compatibility with the latest eslint-plugin-prettier.Testing
The change has been verified by reviewing the configureTools.ts file which now specifies
prettier: '^3.0.0'alongsideeslint-plugin-prettier: '^5.5.4'.