Skip to content

feat(coder/mux): add restart retries for mux exits#800

Merged
DevelopmentCats merged 4 commits intomainfrom
mike/mux-restart-policy
Mar 13, 2026
Merged

feat(coder/mux): add restart retries for mux exits#800
DevelopmentCats merged 4 commits intomainfrom
mike/mux-restart-policy

Conversation

@ibetitsmike
Copy link
Contributor

@ibetitsmike ibetitsmike commented Mar 13, 2026

Summary

  • add optional mux auto-restarts with delay, lock cleanup, and restart-attempt caps
  • restart mux after any exit when enabled, including intentional exits and signals
  • require max_restart_attempts to be a non-negative whole number and update docs/tests for the new restart semantics

Validation

  • bash -n registry/coder/modules/mux/run.sh
  • cd registry/coder/modules/mux && terraform validate
  • cd registry/coder/modules/mux && terraform test -verbose
  • cd registry/coder/modules/mux && bun test main.test.ts

Generated with OpenAI using Mux

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e10ef47ae4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ibetitsmike
Copy link
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ibetitsmike
Copy link
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Contributor

@DevelopmentCats DevelopmentCats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DevelopmentCats DevelopmentCats merged commit 1460293 into main Mar 13, 2026
4 checks passed
@DevelopmentCats DevelopmentCats deleted the mike/mux-restart-policy branch March 13, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants