Fix system tool parser dropping text and blocking follow-up tool calls#11091
Open
siewcapital wants to merge 1 commit intocontinuedev:mainfrom
Open
Fix system tool parser dropping text and blocking follow-up tool calls#11091siewcapital wants to merge 1 commit intocontinuedev:mainfrom
siewcapital wants to merge 1 commit intocontinuedev:mainfrom
Conversation
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Issue #11074 highlights that the current interceptor enforces a positional assumption (single terminal tool call). That causes a capability gap for system-message tool parsing compared with native tool calling behavior.
Testing
core/tools/systemMessageTools/toolCodeblocks/interceptSystemToolCalls.vitest.tsvitest: command not found).Closes #11074
Summary by cubic
Fixes the system tool parser so it preserves assistant text and supports multiple tool codeblocks in a single response instead of stopping after the first call. Closes #11074 and aligns system-message tool parsing with native tool calling.
Written for commit 653adb1. Summary will update on new commits.