Skip to content

fix: use config.yaml name for default Local Config profile#11110

Open
MumuTW wants to merge 3 commits intocontinuedev:mainfrom
MumuTW:fix-local-config-name-11061
Open

fix: use config.yaml name for default Local Config profile#11110
MumuTW wants to merge 3 commits intocontinuedev:mainfrom
MumuTW:fix-local-config-name-11061

Conversation

@MumuTW
Copy link
Contributor

@MumuTW MumuTW commented Mar 6, 2026

Summary

  • read the default profile title from ~/.continue/config.yaml when loading the global local profile
  • keep the existing Local Config fallback when the file is missing, unreadable, or unparseable
  • add a focused LocalProfileLoader regression test covering custom name plus fallback cases

Testing

  • npm run -s vitest -- config/profile/LocalProfileLoader.vitest.ts (fails in this workspace due unresolved local package entry for @continuedev/config-yaml)

Continue Tasks: 🔄 7 running — View all


Summary by cubic

Use the name from ~/.continue/config.yaml as the default Local Config profile title. Falls back to "Local Config" if the file or name is invalid, and no longer falls back when an override file exists but is empty.

  • Bug Fixes
    • Read profile title from global config; fallback to "Local Config" if missing, unreadable, malformed, or blank. Tests cover custom name and fallback cases.
    • Use a strict undefined check for override content so empty override files don’t trigger a global fallback.

Written for commit ac7cc66. Summary will update on new commits.

@MumuTW MumuTW requested a review from a team as a code owner March 6, 2026 05:45
@MumuTW MumuTW requested review from Patrick-Erichsen and removed request for a team March 6, 2026 05:45
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 6, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="core/config/profile/LocalProfileLoader.ts">

<violation number="1" location="core/config/profile/LocalProfileLoader.ts:46">
P2: Falsy check on override content causes empty override files to fall back to global config and potentially assign the wrong profile title.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

MumuTW and others added 2 commits March 6, 2026 09:52
The configYamlSchema requires both name and version fields. The test
only provided name, causing parseConfigYaml to reject the config and
falling back to the default "Local Config" title.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
An empty override file should not fall back to global config.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant