Fix Cursor popup compatibility and add LM Studio onboarding#11226
Open
bcharleson wants to merge 5 commits intocontinuedev:mainfrom
Open
Fix Cursor popup compatibility and add LM Studio onboarding#11226bcharleson wants to merge 5 commits intocontinuedev:mainfrom
bcharleson wants to merge 5 commits intocontinuedev:mainfrom
Conversation
Prevent duplicate activation issues in Cursor, make selector popups render opaquely, and extend local onboarding so LM Studio can be configured alongside Ollama. Made-with: Cursor
Keep local VSIX references and notes out of the repo so Cursor and Antigravity testing assets stay local-only. Made-with: Cursor
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Record the dependency lockfile updates from the local build and packaging workflow used to validate the Cursor and LM Studio compatibility changes. Made-with: Cursor
Contributor
There was a problem hiding this comment.
2 issues found across 16 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="gui/src/components/OnboardingCard/components/OnboardingLocalTab.tsx">
<violation number="1" location="gui/src/components/OnboardingCard/components/OnboardingLocalTab.tsx:98">
P2: Provider switching can use stale `availableLocalModels`, enabling Connect and submitting onboarding with models from the previous provider.</violation>
</file>
<file name="extensions/vscode/src/activation/activate.ts">
<violation number="1" location="extensions/vscode/src/activation/activate.ts:14">
P1: Duplicate-host detection uses a self-contributed command ID, which can be present during normal startup and cause activation to be skipped.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
|
||
| async function isDuplicateHostActivation(): Promise<boolean> { | ||
| const registeredCommands = await vscode.commands.getCommands(true); | ||
| return registeredCommands.includes("continue.focusContinueInput"); |
Contributor
There was a problem hiding this comment.
P1: Duplicate-host detection uses a self-contributed command ID, which can be present during normal startup and cause activation to be skipped.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At extensions/vscode/src/activation/activate.ts, line 14:
<comment>Duplicate-host detection uses a self-contributed command ID, which can be present during normal startup and cause activation to be skipped.</comment>
<file context>
@@ -9,7 +9,19 @@ import { GlobalContext } from "core/util/GlobalContext";
+async function isDuplicateHostActivation(): Promise<boolean> {
+ const registeredCommands = await vscode.commands.getCommands(true);
+ return registeredCommands.includes("continue.focusContinueInput");
+}
+
</file context>
| ]); | ||
|
|
||
| useEffect(() => { | ||
| setHasLoadedChatModel(false); |
Contributor
There was a problem hiding this comment.
P2: Provider switching can use stale availableLocalModels, enabling Connect and submitting onboarding with models from the previous provider.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At gui/src/components/OnboardingCard/components/OnboardingLocalTab.tsx, line 98:
<comment>Provider switching can use stale `availableLocalModels`, enabling Connect and submitting onboarding with models from the previous provider.</comment>
<file context>
@@ -31,67 +31,90 @@ export function OnboardingLocalTab({ isDialog }: OnboardingLocalTabProps) {
+ ]);
+
+ useEffect(() => {
+ setHasLoadedChatModel(false);
+ }, [localProvider]);
</file context>
Suggested change
| setHasLoadedChatModel(false); | |
| setHasLoadedChatModel(false); | |
| setAvailableLocalModels([]); | |
| setIsProviderConnected(false); |
Resolve the package-lock merge conflicts and bring the feature branch back in sync with upstream main. Made-with: Cursor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
Make the repo-root Tailwind config safe for CI formatting and resync the VS Code extension lockfile so npm ci and downstream VS Code checks pass. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
npm run tsc:checkincorenpm run buildinguinpm run packageinextensions/vscodenpm run vitest -- onboarding.vitest.tsincore/configcontinue-1.3.33.vsixin Cursor and verify opaque popups plus LM Studio onboardingMade with Cursor
Summary by cubic
Fixes Cursor activation conflicts and translucent popups. Adds
LM Studioonboarding with auto-detected local models and provider selection alongsideOllama.Bug Fixes
continue.viewLogsisn’t registered.tailwind.config.cjsfor CI formatting, sync VS Code extension lockfile to1.3.33, and ignorelocal-artifacts/.New Features
LM Studiolocal onboarding: detect available models, auto-assign roles (chat/autocomplete/embed), and write config.LM Studiomodels in core and passing detected titles through the onboarding flow.OllamaorLM Studio) and show detectedLM Studiomodels and connection status.vitestfor onboarding model selection and config generation.Written for commit 47ae277. Summary will update on new commits.